All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull V2] headers_check fixes
Date: Fri, 30 Jan 2009 21:40:36 +0100	[thread overview]
Message-ID: <200901302140.37432.arnd@arndb.de> (raw)
In-Reply-To: <20090130192627.GA32705@elte.hu>

On Friday 30 January 2009, Ingo Molnar wrote:
> Sam, would you mind to remove the CONFIG_* warnings from headers_check, 
> and get that commit to Linus ASAP? (or we can put it into this branch too, 
> if you prefer it that way)
> 
> Those warnings wont be worked around in the headers and that check litters 
> the CONFIG_HEADER_CHECK=y build with warnings right now and make it 
> impossible to reach a warning-free build.

I double-checked the remaining CONFIG_* warnings in this version to make sure
that we are not dropping any warnings about actual bugs. There are a few places
where the kernel exports more than it should, but there is a lot more of that
without warnings, so that's fine.

The only places that believe to be bugs that needs fixing are in
<linux/kvm.h> and <asm-x86/ptrace-abi.h>. Avi has a patch for kvm.h
that in the kvm tree.

Below, you can find a patch for the remaining problem.

	Arnd <><
---

Subject: x86: export PTRACE_BTS interfaces to user space

The definitions for PTRACE_BTS_* are inside of #ifdef CONFIG_X86_PTRACE_BTS,
which means that they are invisible to user space. Remove the #ifdef so
that the interface becomes visible.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

--- a/arch/x86/include/asm/ptrace-abi.h
+++ b/arch/x86/include/asm/ptrace-abi.h
@@ -80,8 +80,6 @@
 
 #define PTRACE_SINGLEBLOCK	33	/* resume execution until next branch */
 
-#ifdef CONFIG_X86_PTRACE_BTS
-
 #ifndef __ASSEMBLY__
 #include <linux/types.h>
 
@@ -140,6 +138,5 @@ struct ptrace_bts_config {
    BTS records are read from oldest to newest.
    Returns number of BTS records drained.
 */
-#endif /* CONFIG_X86_PTRACE_BTS */
 
 #endif /* _ASM_X86_PTRACE_ABI_H */

  reply	other threads:[~2009-01-30 20:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 19:04 [git pull V2] headers_check fixes Jaswinder Singh Rajput
2009-01-30 19:26 ` Ingo Molnar
2009-01-30 20:40   ` Arnd Bergmann [this message]
2009-01-30 22:56   ` [PATCH] kbuild: drop check for CONFIG_ in headers_check Sam Ravnborg
2009-01-30 23:40     ` Ingo Molnar
2009-01-31  0:27       ` Arnd Bergmann
2009-01-31  0:41         ` Ingo Molnar
2009-01-31  1:06           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901302140.37432.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.