From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check
Date: Sat, 31 Jan 2009 00:40:12 +0100 [thread overview]
Message-ID: <20090130234012.GF4922@elte.hu> (raw)
In-Reply-To: <20090130225642.GA17950@uranus.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> wrote:
> The check for references to CONFIG_ symbols in exported headers turned
> out to be too agressive with the current state of affairs.
> After the work of Jaswinder to clean up all relevant cases we are down
> to almost pure noise.
>
> So lets drop the check for now - we can always add it back later
> should our headers be ready for that.
>
> Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> Hi Ingo.
> Please include this in the tip/core/header-fixes brach
> as this is the natural path towards mainline.
>
> Jaswinder - thanks for your effort chasing all these warnings!
Applied to tip/core/header-fixes, thanks Sam for the quick patch!
Jaswinder, i think we now have a realistic chance to reach a zero baseline
with these warnings, for v2.6.29. Here are the remaining warnings (summed
up per file) on x86 (after Sam's patch):
17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
12 /dev/shm/tip/usr/include/linux/soundcard.h
3 /dev/shm/tip/usr/include/linux/nubus.h
2 /dev/shm/tip/usr/include/linux/in6.h
1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
1 /dev/shm/tip/usr/include/linux/socket.h
1 /dev/shm/tip/usr/include/linux/coda_psdev.h
1 /dev/shm/tip/usr/include/linux/bsg.h
Ingo
next prev parent reply other threads:[~2009-01-30 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 19:04 [git pull V2] headers_check fixes Jaswinder Singh Rajput
2009-01-30 19:26 ` Ingo Molnar
2009-01-30 20:40 ` Arnd Bergmann
2009-01-30 22:56 ` [PATCH] kbuild: drop check for CONFIG_ in headers_check Sam Ravnborg
2009-01-30 23:40 ` Ingo Molnar [this message]
2009-01-31 0:27 ` Arnd Bergmann
2009-01-31 0:41 ` Ingo Molnar
2009-01-31 1:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130234012.GF4922@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.