What is not in git.git

What is not in git.git

[Nanako Shiraishi]

You keep mentioning 1.6.2 and I take it as a hint that the project is
approaching the pre release freeze. There are some patches sent to the
list that are not in git.git, and I am wondering what their statuses are.

 1. From: ecashin@coraid.com
    Subject: [PATCH] git-describe documentation: --match pattern is glob
    Date: Thu, 22 Jan 2009 11:21:53 -0500
    Message-ID: <dfa634dbd8def9e205bbe219217179ca@coraid.com>

    I thought this was correct, but was missing a sign-off. Perhaps it was
    dropped on the floor because it was sent in a wrong format that is
    harder to apply?

 2. From: Arjen Laarhoven <arjen@yaph.org>
    Subject: [PATCH 2/2] git-log: Follow file copies with 'git log --follow -C -C'
    Date: Thu, 22 Jan 2009 17:37:25 +0100
    Message-ID: <1232642245-94405-2-git-send-email-arjen@yaph.org>

    Junio seemed to like the patch but asked a question; I did not see a
    response nor updated patch (sorry, I do not read C and cannot comment
    on the correctness of the patch).

 3. From: Joey Hess <joey@kitenet.net>
    Subject: [PATCH] gitweb: support the rel=vcs microformat
    Date: Tue, 6 Jan 2009 23:25:18 -0500
    Message-ID: <20090107042518.GB24735@gnu.kitenet.net>

    A few exchanges of review comments and responses, and then this topic
    went dark.

    From: Benjamin Kramer <benny.kra@googlemail.com>
    Subject: [PATCH] Makefile: Use libc strlcpy on OSX
    Date: Sat, 24 Jan 2009 16:41:30 +0100
    Message-ID: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com>

    My reading of the thread is that the only remaining issue was to limit
    the change to specific versions, and I think people who use OSX can help
    polish this topic to completion.

 4. From: Pete Wyckoff <pw@padd.com>
    Subject: [PATCH] git-p4: avoid syncing duplicate changes
    Date: Wed, 28 Jan 2009 08:45:40 -0800
    Message-ID: <20090128164540.GA2137@padd.com>

    Nobody commented on this as far as I can tell. Do people not care
    about p4? Simon Hausmann seem to be the most recent active contributor
    and perhaps he can comment on this patch.

 5. From: jidanni@jidanni.org
    Subject: [PATCH] Documentation/git-show-branch.txt: compact -g
    Date: Tue,  6 Jan 2009 11:14:02 +0800
    Message-Id: <1231211642-14463-1-git-send-email-jidanni@jidanni.org>

    I couldn't figure out what "compact -g" meant but other than that I
    think this patch is correct. Perhaps Junio has the author in his mail
    ignore list?

 6. From: Alexander Potashev <aspotashev@gmail.com>
    Subject: [PATCH] Replace deprecated dashed git commands in usage
    Date: Sun,  4 Jan 2009 21:39:27 +0300
    Message-ID: <1231094367-8831-1-git-send-email-aspotashev@gmail.com>

    This should have been in 1.6.0 already but it is still not.
    Forgotten?

 7. From: Dirk Hörner <dirker@gmail.com>
    Subject: [PATCH] git-cvsimport: add support for cvs pserver password scrambling.
    Date: Fri, 28 Nov 2008 20:06:40 +0200
    Message-ID: <5794AED2-43FF-4441-8292-0C9BFB3139A2@gmail.com>

    I think Johannes Schindelin commented but then nothing happened to
    this patch. Is there any more work necessary for its inclusion?

 8. From: Heikki Hokkanen <hoxu@users.sf.net>
    Subject: [PATCH] git show-ref: add --remotes option.
    Date: Mon, 13 Oct 2008 22:23:47 +0300
    Message-ID: <48F3A043.5070406@users.sf.net>

    I saw no comments but it is consistent with how git-rev-list allows
    you say branches and tags. Is there anything wrong with the patch?

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

Re: What is not in git.git

[Junio C Hamano]

Nanako Shiraishi <nanako3@lavabit.com> writes:

> You keep mentioning 1.6.2 and I take it as a hint that the project is
> approaching the pre release freeze. There are some patches sent to the
> list that are not in git.git, and I am wondering what their statuses are.
>
>  1. From: ecashin@coraid.com
>     Subject: [PATCH] git-describe documentation: --match pattern is glob
>     Date: Thu, 22 Jan 2009 11:21:53 -0500
>     Message-ID: <dfa634dbd8def9e205bbe219217179ca@coraid.com>
>
>     I thought this was correct, but was missing a sign-off. Perhaps it was
>     dropped on the floor because it was sent in a wrong format that is
>     harder to apply?

Mostly correct, but because we consider refnames like filesystem paths and
the use of globs when matching them is shared as the same basic design
across commands, I do not think the manual page for each individual
command is the right place to say it.

>  2. From: Arjen Laarhoven <arjen@yaph.org>
>     Subject: [PATCH 2/2] git-log: Follow file copies with 'git log --follow -C -C'
>     Date: Thu, 22 Jan 2009 17:37:25 +0100
>     Message-ID: <1232642245-94405-2-git-send-email-arjen@yaph.org>
>
>     Junio seemed to like the patch but asked a question; I did not see a
>     response nor updated patch (sorry, I do not read C and cannot comment
>     on the correctness of the patch).

Thanks for a reminder, and no, don't be sorry.  This type of "project
secretary" help is very much appreciated, and you are demonstrating that
you do not have to know the code very intimately to do this, which is also
very good.

>  3. From: Joey Hess <joey@kitenet.net>
>     Subject: [PATCH] gitweb: support the rel=vcs microformat
>     Date: Tue, 6 Jan 2009 23:25:18 -0500
>     Message-ID: <20090107042518.GB24735@gnu.kitenet.net>
>
>     A few exchanges of review comments and responses, and then this topic
>     went dark.

This is in "The author will come back if he feels strongly enough, so I
can safely forget about it. I am not qualified to take over as the primary
promoter of the topic if the author abandones it anyway" (aka "not mine")
category.

>     From: Benjamin Kramer <benny.kra@googlemail.com>
>     Subject: [PATCH] Makefile: Use libc strlcpy on OSX
>     Date: Sat, 24 Jan 2009 16:41:30 +0100
>     Message-ID: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com>
>
>     My reading of the thread is that the only remaining issue was to limit
>     the change to specific versions, and I think people who use OSX can help
>     polish this topic to completion.

Likewise.

>  4. From: Pete Wyckoff <pw@padd.com>
>     Subject: [PATCH] git-p4: avoid syncing duplicate changes
>     Date: Wed, 28 Jan 2009 08:45:40 -0800
>     Message-ID: <20090128164540.GA2137@padd.com>
>
>     Nobody commented on this as far as I can tell. Do people not care
>     about p4? Simon Hausmann seem to be the most recent active contributor
>     and perhaps he can comment on this patch.

Likewise.

>  5. From: jidanni@jidanni.org
>     Subject: [PATCH] Documentation/git-show-branch.txt: compact -g
>     Date: Tue,  6 Jan 2009 11:14:02 +0800
>     Message-Id: <1231211642-14463-1-git-send-email-jidanni@jidanni.org>
>
>     I couldn't figure out what "compact -g" meant but other than that I
>     think this patch is correct. Perhaps Junio has the author in his mail
>     ignore list?

I do not have anybody in my killfile.  I think this patch is Ok with a
minor fix to log as you say.  How about

	git-show-branch doc: show -g as synonym to --reflog in the list

>  6. From: Alexander Potashev <aspotashev@gmail.com>
>     Subject: [PATCH] Replace deprecated dashed git commands in usage
>     Date: Sun,  4 Jan 2009 21:39:27 +0300
>     Message-ID: <1231094367-8831-1-git-send-email-aspotashev@gmail.com>
>
>     This should have been in 1.6.0 already but it is still not.
>     Forgotten?

I haven't looked at it.  As long as it only touches the messages and not
strings used to invoke other commands with their names, there shouldn't be
any downside.

>  7. From: Dirk Hörner <dirker@gmail.com>
>     Subject: [PATCH] git-cvsimport: add support for cvs pserver password scrambling.
>     Date: Fri, 28 Nov 2008 20:06:40 +0200
>     Message-ID: <5794AED2-43FF-4441-8292-0C9BFB3139A2@gmail.com>
>
>     I think Johannes Schindelin commented but then nothing happened to
>     this patch. Is there any more work necessary for its inclusion?

Again, this is in "not mine" category.

>  8. From: Heikki Hokkanen <hoxu@users.sf.net>
>     Subject: [PATCH] git show-ref: add --remotes option.
>     Date: Mon, 13 Oct 2008 22:23:47 +0300
>     Message-ID: <48F3A043.5070406@users.sf.net>
>
>     I saw no comments but it is consistent with how git-rev-list allows
>     you say branches and tags. Is there anything wrong with the patch?

Hmm, ... goes to the archive ... I guess this shouldn't hurt.

Thanks.  I wish there were more like you.

Re: What is not in git.git

[Joey Hess]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Junio C Hamano wrote:
> >  3. From: Joey Hess <joey@kitenet.net>
> >     Subject: [PATCH] gitweb: support the rel=vcs microformat
> >     Date: Tue, 6 Jan 2009 23:25:18 -0500
> >     Message-ID: <20090107042518.GB24735@gnu.kitenet.net>
> >
> >     A few exchanges of review comments and responses, and then this topic
> >     went dark.
> 
> This is in "The author will come back if he feels strongly enough, so I
> can safely forget about it. I am not qualified to take over as the primary
> promoter of the topic if the author abandones it anyway" (aka "not mine")
> category.

Indeed. I've been meaning to get back to it and do a patch series
addressing Jakub's feedback, but have not yet.
 
-- 
see shy jo

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: What is not in git.git

[Nanako Shiraishi]

Quoting Junio C Hamano <gitster@pobox.com> writes:

> Nanako Shiraishi <nanako3@lavabit.com> writes:
>
>>  5. From: jidanni@jidanni.org
>>     Subject: [PATCH] Documentation/git-show-branch.txt: compact -g
>>     Date: Tue,  6 Jan 2009 11:14:02 +0800
>>     Message-Id: <1231211642-14463-1-git-send-email-jidanni@jidanni.org>
>>
>>     I couldn't figure out what "compact -g" meant but other than that I
>>     think this patch is correct. Perhaps Junio has the author in his mail
>>     ignore list?
>
> I do not have anybody in my killfile.  I think this patch is Ok with a
> minor fix to log as you say.  How about
>
> 	git-show-branch doc: show -g as synonym to --reflog in the list

That is very readable.

> Thanks.  I wish there were more like you.

You're welcome.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

Re: What is not in git.git

[Ed Cashin]

On Wed, Feb 04, 2009 at 02:49:00PM -0800, Junio C Hamano wrote:
> Nanako Shiraishi <nanako3@lavabit.com> writes:
...
> >  1. From: ecashin@coraid.com
> >     Subject: [PATCH] git-describe documentation: --match pattern is glob
> >     Date: Thu, 22 Jan 2009 11:21:53 -0500
> >     Message-ID: <dfa634dbd8def9e205bbe219217179ca@coraid.com>
> >
> >     I thought this was correct, but was missing a sign-off. Perhaps it was
> >     dropped on the floor because it was sent in a wrong format that is
> >     harder to apply?
> 
> Mostly correct, but because we consider refnames like filesystem paths and
> the use of globs when matching them is shared as the same basic design
> across commands, I do not think the manual page for each individual
> command is the right place to say it.

I can add a sign-off if that would help, but it sounds like it was the
wrong fix.  I didn't know the right place to say it, but I figure: If
there is a right place, then what is it?  If there isn't one, saying
it in the git-describe manpage is probably a good step for now.

-- 
  Ed Cashin <ecashin@coraid.com>