From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Steven Rostedt <srostedt@redhat.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/3] powerpc: Make it possible to safely select CONFIG_FRAME_POINTER
Date: Thu, 5 Feb 2009 04:30:23 +0300 [thread overview]
Message-ID: <20090205013023.GA31417@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1233796531.4612.35.camel@pasglop>
On Thu, Feb 05, 2009 at 12:15:31PM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-02-04 at 19:35 -0500, Steven Rostedt wrote:
> > On Thu, 2009-02-05 at 11:31 +1100, Benjamin Herrenschmidt wrote:
> > > On Wed, 2009-02-04 at 18:08 +0300, Anton Vorontsov wrote:
> > > > Remove -fno-omit-frame-pointer flag from CFLAGS.
> > > > Remove -fno-omit-frame-pointer workarounds.
> > >
> > > But what about -pg -requires -fno-omit-frame-pointer ?
> >
> > I don't think it requires -fno-omit-frame-pointer. It is just
> > incompatible with -fomit-frame-pointer.
>
> From a quick test, you seem to be right.
>
> Now the question of course is whether -pg will internally trigger
> the bug for which we need the workaround tho...
According to http://marc.info/?l=linux-kernel&m=121958694215835&w=4
just removing -fno-omit-frame-pointer solved the problem.
But I'll double check that on the actual hardware.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Steven Rostedt <srostedt@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 2/3] powerpc: Make it possible to safely select CONFIG_FRAME_POINTER
Date: Thu, 5 Feb 2009 04:30:23 +0300 [thread overview]
Message-ID: <20090205013023.GA31417@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1233796531.4612.35.camel@pasglop>
On Thu, Feb 05, 2009 at 12:15:31PM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-02-04 at 19:35 -0500, Steven Rostedt wrote:
> > On Thu, 2009-02-05 at 11:31 +1100, Benjamin Herrenschmidt wrote:
> > > On Wed, 2009-02-04 at 18:08 +0300, Anton Vorontsov wrote:
> > > > Remove -fno-omit-frame-pointer flag from CFLAGS.
> > > > Remove -fno-omit-frame-pointer workarounds.
> > >
> > > But what about -pg -requires -fno-omit-frame-pointer ?
> >
> > I don't think it requires -fno-omit-frame-pointer. It is just
> > incompatible with -fomit-frame-pointer.
>
> From a quick test, you seem to be right.
>
> Now the question of course is whether -pg will internally trigger
> the bug for which we need the workaround tho...
According to http://marc.info/?l=linux-kernel&m=121958694215835&w=4
just removing -fno-omit-frame-pointer solved the problem.
But I'll double check that on the actual hardware.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-02-05 1:30 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 19:06 [PATCH] ftrace: On PowerPC we don't need frame pointers for CALLER_ADDRs Anton Vorontsov
2009-01-31 19:06 ` Anton Vorontsov
2009-02-02 0:35 ` Benjamin Herrenschmidt
2009-02-02 0:35 ` Benjamin Herrenschmidt
2009-02-02 14:04 ` Steven Rostedt
2009-02-02 14:04 ` Steven Rostedt
2009-02-03 14:56 ` [PATCH v2] " Anton Vorontsov
2009-02-03 14:56 ` Anton Vorontsov
2009-02-03 16:06 ` Ingo Molnar
2009-02-03 16:06 ` Ingo Molnar
2009-02-03 16:19 ` Anton Vorontsov
2009-02-03 16:19 ` Anton Vorontsov
2009-02-03 16:32 ` Steven Rostedt
2009-02-03 16:32 ` Steven Rostedt
2009-02-03 18:59 ` Anton Vorontsov
2009-02-03 18:59 ` Anton Vorontsov
2009-02-04 0:34 ` Benjamin Herrenschmidt
2009-02-04 0:34 ` Benjamin Herrenschmidt
2009-02-04 15:07 ` Anton Vorontsov
2009-02-04 15:07 ` Anton Vorontsov
2009-02-04 15:08 ` [PATCH 1/3] Makefile: Include arch Makefiles as late as possible Anton Vorontsov
2009-02-04 15:08 ` Anton Vorontsov
2009-02-04 15:08 ` Anton Vorontsov
2009-02-04 21:26 ` Ingo Molnar
2009-02-04 21:26 ` Ingo Molnar
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-11 13:23 ` Ingo Molnar
2009-02-11 13:23 ` Ingo Molnar
2009-02-11 14:11 ` Steven Rostedt
2009-02-11 14:11 ` Steven Rostedt
2009-02-11 14:11 ` Steven Rostedt
2009-02-11 14:11 ` Steven Rostedt
2009-02-11 14:11 ` Steven Rostedt
2009-02-14 19:58 ` Sam Ravnborg
2009-02-14 19:58 ` Sam Ravnborg
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-11 3:51 ` Benjamin Herrenschmidt
2009-02-14 19:57 ` Sam Ravnborg
2009-02-14 19:57 ` Sam Ravnborg
2009-02-14 22:03 ` Ingo Molnar
2009-02-14 22:03 ` Ingo Molnar
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 0:19 ` Benjamin Herrenschmidt
2009-02-15 8:09 ` Ingo Molnar
2009-02-15 8:09 ` Ingo Molnar
2009-02-16 14:20 ` Anton Vorontsov
2009-02-16 14:20 ` Anton Vorontsov
2009-02-16 14:20 ` Anton Vorontsov
2009-02-16 14:53 ` Anton Vorontsov
2009-02-16 14:53 ` Anton Vorontsov
2009-02-16 20:04 ` Sam Ravnborg
2009-02-16 20:04 ` Sam Ravnborg
2009-02-16 16:08 ` Anton Vorontsov
2009-02-16 16:08 ` Anton Vorontsov
2009-02-16 17:22 ` Ingo Molnar
2009-02-16 17:22 ` Ingo Molnar
2009-02-04 21:26 ` Ingo Molnar
2009-02-04 21:26 ` Ingo Molnar
2009-02-04 21:26 ` Ingo Molnar
2009-02-04 15:08 ` [PATCH 2/3] powerpc: Make it possible to safely select CONFIG_FRAME_POINTER Anton Vorontsov
2009-02-04 15:08 ` Anton Vorontsov
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-05 0:35 ` Steven Rostedt
2009-02-05 0:35 ` Steven Rostedt
2009-02-05 1:12 ` Anton Vorontsov
2009-02-05 1:12 ` Anton Vorontsov
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:15 ` Benjamin Herrenschmidt
2009-02-05 1:30 ` Anton Vorontsov [this message]
2009-02-05 1:30 ` Anton Vorontsov
2009-02-05 15:45 ` Anton Vorontsov
2009-02-05 15:45 ` Anton Vorontsov
2009-02-05 0:31 ` Benjamin Herrenschmidt
2009-02-04 15:08 ` [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER Anton Vorontsov
2009-02-04 15:08 ` Anton Vorontsov
2009-02-04 15:26 ` Frédéric Weisbecker
2009-02-04 15:26 ` Frédéric Weisbecker
2009-02-04 15:26 ` Frédéric Weisbecker
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:31 ` Steven Rostedt
2009-02-04 15:36 ` Anton Vorontsov
2009-02-04 15:36 ` Anton Vorontsov
2009-02-04 15:36 ` Anton Vorontsov
2009-02-04 16:50 ` Frédéric Weisbecker
2009-02-04 16:50 ` Frédéric Weisbecker
2009-02-04 16:50 ` Frédéric Weisbecker
2009-02-04 8:17 ` [PATCH v2] ftrace: On PowerPC we don't need frame pointers forCALLER_ADDRs Usha Rani Konudula
2009-02-04 8:17 ` Usha Rani Konudula
2009-02-04 8:37 ` Usha Rani Konudula
2009-02-04 8:37 ` Usha Rani Konudula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205013023.GA31417@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.