diff for duplicates of <20090205085916.GP24173@disturbed> diff --git a/a/1.txt b/N1/1.txt index fca8da2..69e75e8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,29 +2,28 @@ On Wed, Feb 04, 2009 at 07:29:51PM +0100, Pavel Machek wrote: > On Sun 2009-02-01 12:40:50, Dave Chinner wrote: > > On Mon, Jan 26, 2009 at 05:27:11PM +0100, Pavel Machek wrote: > > > On Wed 2009-01-21 15:00:42, Dave Chinner wrote: -> > > + Turning this option on will result in kernel panicking any ti= -me +> > > + Turning this option on will result in kernel panicking any time > > > + it detects on-disk corruption. -> >=20 +> > > > Thin end of a wedge. There's a couple of thousand conditions that > > CONFIG_XFS_DEBUG introduces kernel panics on: -> >=20 +> > > > $ grep -r ASSERT fs/xfs |wc -l > > 2095 -> >=20 -> >=20 +> > +> > > > CONFIG_*_DEBUG means include *debug* code there to help developers, > > including adding additional failure tests into the kernel. Besides, > > which bit of "don't turn it on unless you are an XFS developer" > > don't you understand? ->=20 +> > Yes, but DEBUG code is normally to help debugging, not to crash > kernels. Crashing the kernel at exactly the point a problem is detected is often the simplest way of debugging the problem. -e.g. CONFIG_VM_DEBUG=3Dy turns on VM_BUG_ON() which crashes the kernel +e.g. CONFIG_VM_DEBUG=y turns on VM_BUG_ON() which crashes the kernel whenever it detects something wrong. Do I turn it on? Yes. Do i complain about it when I hit a VM_BUG_ON()? No, I report the bug and move on. If you turn on a DEBUG option, then you are @@ -32,7 +31,7 @@ asking the system to behave in a way useful to a developer, not an end user. That includes panicing when something wrong is detected. -> IMO xfs should use errors=3Dpanic mount option as ext3 does, +> IMO xfs should use errors=panic mount option as ext3 does, > but... We already have an equivalent: @@ -41,18 +40,12 @@ We already have an equivalent: The mask is empty on production kernels and can be selectively turned on (depending on what error type you want to panic on). -CONFIG_XFS_DEBUG turns them all on by default so we can, we=C4=BCl, pan= -ic +CONFIG_XFS_DEBUG turns them all on by default so we can, weļl, panic the system and debug any problem that occurs.... Cheers, Dave, ---=20 +-- Dave Chinner david@fromorbit.com --- -To unsubscribe from this list: send the line "unsubscribe linux-btrfs" = -in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index b4c1b23..bc23167 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,29 +23,28 @@ "> On Sun 2009-02-01 12:40:50, Dave Chinner wrote:\n" "> > On Mon, Jan 26, 2009 at 05:27:11PM +0100, Pavel Machek wrote:\n" "> > > On Wed 2009-01-21 15:00:42, Dave Chinner wrote:\n" - "> > > +\t Turning this option on will result in kernel panicking any ti=\n" - "me\n" + "> > > +\t Turning this option on will result in kernel panicking any time\n" "> > > +\t it detects on-disk corruption.\n" - "> >=20\n" + "> > \n" "> > Thin end of a wedge. There's a couple of thousand conditions that\n" "> > CONFIG_XFS_DEBUG introduces kernel panics on:\n" - "> >=20\n" + "> > \n" "> > $ grep -r ASSERT fs/xfs |wc -l\n" "> > 2095\n" - "> >=20\n" - "> >=20\n" + "> > \n" + "> > \n" "> > CONFIG_*_DEBUG means include *debug* code there to help developers,\n" "> > including adding additional failure tests into the kernel. Besides,\n" "> > which bit of \"don't turn it on unless you are an XFS developer\"\n" "> > don't you understand?\n" - ">=20\n" + "> \n" "> Yes, but DEBUG code is normally to help debugging, not to crash\n" "> kernels.\n" "\n" "Crashing the kernel at exactly the point a problem is detected\n" "is often the simplest way of debugging the problem.\n" "\n" - "e.g. CONFIG_VM_DEBUG=3Dy turns on VM_BUG_ON() which crashes the kernel\n" + "e.g. CONFIG_VM_DEBUG=y turns on VM_BUG_ON() which crashes the kernel\n" "whenever it detects something wrong. Do I turn it on? Yes. Do i\n" "complain about it when I hit a VM_BUG_ON()? No, I report the\n" "bug and move on. If you turn on a DEBUG option, then you are\n" @@ -53,7 +52,7 @@ "not an end user. That includes panicing when something wrong\n" "is detected.\n" "\n" - "> IMO xfs should use errors=3Dpanic mount option as ext3 does,\n" + "> IMO xfs should use errors=panic mount option as ext3 does,\n" "> but...\n" "\n" "We already have an equivalent:\n" @@ -62,20 +61,14 @@ "\n" "The mask is empty on production kernels and can be selectively\n" "turned on (depending on what error type you want to panic on).\n" - "CONFIG_XFS_DEBUG turns them all on by default so we can, we=C4=BCl, pan=\n" - "ic\n" + "CONFIG_XFS_DEBUG turns them all on by default so we can, we\304\274l, panic\n" "the system and debug any problem that occurs....\n" "\n" "Cheers,\n" "\n" "Dave,\n" - "--=20\n" + "-- \n" "Dave Chinner\n" - "david@fromorbit.com\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-btrfs\" =\n" - "in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + david@fromorbit.com -eee8c1d63a33efbc30203cdf97d9931f9d978553244777ab94321f36970b239f +c0634b7d628fb3b411ee63ed958b80ff75218c53d506d433e18ec548d352cd5a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.