[PATCH] alsa: snd_pcm_new api cleanup

[PATCH] alsa: snd_pcm_new api cleanup

[Tim Blechmann]

Impact: cleanup

snd_pcm_new takes a char *id argument, although it is not modifying
the string. it can therefore be declared as const char *id.

Signed-off-by: Tim Blechmann <tim@klingt.org>
---
 sound/core/pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 192a433..583453e 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -692,7 +692,7 @@ EXPORT_SYMBOL(snd_pcm_new_stream);
  *
  * Returns zero if successful, or a negative error code on failure.
  */
-int snd_pcm_new(struct snd_card *card, char *id, int device,
+int snd_pcm_new(struct snd_card *card, const char *id, int device,
 		int playback_count, int capture_count,
 	        struct snd_pcm ** rpcm)
 {
-- 
1.5.6.3

Re: [PATCH] alsa: snd_pcm_new api cleanup

[Takashi Iwai]

At Thu, 5 Feb 2009 12:27:15 +0100,
Tim Blechmann wrote:
> 
> Impact: cleanup
> 
> snd_pcm_new takes a char *id argument, although it is not modifying
> the string. it can therefore be declared as const char *id.
> 
> Signed-off-by: Tim Blechmann <tim@klingt.org>
> ---
>  sound/core/pcm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index 192a433..583453e 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -692,7 +692,7 @@ EXPORT_SYMBOL(snd_pcm_new_stream);
>   *
>   * Returns zero if successful, or a negative error code on failure.
>   */
> -int snd_pcm_new(struct snd_card *card, char *id, int device,
> +int snd_pcm_new(struct snd_card *card, const char *id, int device,
>  		int playback_count, int capture_count,
>  	        struct snd_pcm ** rpcm)
>  {

Don't forget to fix include/sound/pcm.h, too.

Or, more better, please test the build once before submitting patches :)


thanks,

Takashi

[PATCH] alsa: snd_pcm_new api cleanup

[Tim Blechmann]

Impact: cleanup

snd_pcm_new takes a char *id argument, although it is not modifying
the string. it can therefore be declared as const char *id.

Signed-off-by: Tim Blechmann <tim@klingt.org>
---
 include/sound/pcm.h |    2 +-
 sound/core/pcm.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 40c5a6f..ee0e887 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -451,7 +451,7 @@ struct snd_pcm_notify {
 
 extern const struct file_operations snd_pcm_f_ops[2];
 
-int snd_pcm_new(struct snd_card *card, char *id, int device,
+int snd_pcm_new(struct snd_card *card, const char *id, int device,
 		int playback_count, int capture_count,
 		struct snd_pcm **rpcm);
 int snd_pcm_new_stream(struct snd_pcm *pcm, int stream, int substream_count);
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 192a433..583453e 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -692,7 +692,7 @@ EXPORT_SYMBOL(snd_pcm_new_stream);
  *
  * Returns zero if successful, or a negative error code on failure.
  */
-int snd_pcm_new(struct snd_card *card, char *id, int device,
+int snd_pcm_new(struct snd_card *card, const char *id, int device,
 		int playback_count, int capture_count,
 	        struct snd_pcm ** rpcm)
 {
-- 
1.5.6.3

Re: [PATCH] alsa: snd_pcm_new api cleanup

[Tim Blechmann]

[-- Attachment #1.1: Type: text/plain, Size: 289 bytes --]

> Don't forget to fix include/sound/pcm.h, too.
> 
> Or, more better, please test the build once before submitting patches :)

hrm, compiled wrong source tree :/

best, tim

-- 
tim@klingt.org
http://tim.klingt.org

The composer makes plans, music laughs.
  Morton Feldman


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] alsa: snd_pcm_new api cleanup

[Takashi Iwai]

At Thu, 5 Feb 2009 13:01:54 +0100,
Tim Blechmann wrote:
> 
> Impact: cleanup
> 
> snd_pcm_new takes a char *id argument, although it is not modifying
> the string. it can therefore be declared as const char *id.
> 
> Signed-off-by: Tim Blechmann <tim@klingt.org>

Applied now.  Thanks.


Takashi