Re: [PATCH 3/6] i2c: ignore active clients detaching during adapter removal.

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Thursday 05 February 2009, Rodolfo Giometti wrote:
> 
> When we are removing an adapter we decide to ignore any active client
> detaching faults for two reasons:
> 
> 1) one (or more) active client may be switched off, so it cannot
>    replay to the "adapter removed" event.
> 
> 2) it shouldn't happen, and even if it happens it may be due a bus
>    fault which can be resolved by resetting the adapter (most of them
>    can be resetted simply by rmmod and then insmod the module again).

This bothers me.  If the client can't detach, it can't;
there may be all kinds of chaos introduced by trying
to fake success in such cases.  Like resources that
suddenly just vanish, leaving breakage in their wake.

If this is a shutdown() path, where it's basically
just a polite driver notification, that's one thing.

But I2C gets used as a system control bus, so this
sort of "ignore the errors" stuff worries me a lot.

- Dave