From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Tejun Heo <htejun@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brian Gerst <brgerst@gmail.com>,
Xen-devel <xen-devel@lists.xensource.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: style fascism for xen assemblies
Date: Thu, 5 Feb 2009 18:34:30 +0100 [thread overview]
Message-ID: <20090205173430.GA9233@elte.hu> (raw)
In-Reply-To: <498B226A.2020900@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Tejun Heo wrote:
>> Impact: style cleanup
>>
>> Make the following sytle cleanups.
>>
>> * drop unnecessary //#include from xen-asm_32.S
>>
> Fine.
>> * compulsive adding of space after comma
>>
> Fine.
>> * reformat multiline comments
>>
>
> I don't really like what you've done here. There are two problems:
>
> * If you're going to convert comments of the form
>
> /* This is a small comment which
> happens to be longer than a line. */
>
>
> then you should convert it to full winged-style, rather than just
> sticking '*' on the front of the second line.
> * All the big block comments look crowded and cramped now, which
> makes them harder to read and maintain. All those '*'s are just
> visual noise. (They make a bit more sense in C code to distinguish
> comment from code, but asm code looks so different from comment
> that they're not necessary here.)
>
> But Ingo's already pulled it, so I guess I'm stuck with it.
i pulled it and i already fixed all the proper winged style comments as
well. Could you double-check the end result please?
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
Brian Gerst <brgerst@gmail.com>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: style fascism for xen assemblies
Date: Thu, 5 Feb 2009 18:34:30 +0100 [thread overview]
Message-ID: <20090205173430.GA9233@elte.hu> (raw)
In-Reply-To: <498B226A.2020900@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Tejun Heo wrote:
>> Impact: style cleanup
>>
>> Make the following sytle cleanups.
>>
>> * drop unnecessary //#include from xen-asm_32.S
>>
> Fine.
>> * compulsive adding of space after comma
>>
> Fine.
>> * reformat multiline comments
>>
>
> I don't really like what you've done here. There are two problems:
>
> * If you're going to convert comments of the form
>
> /* This is a small comment which
> happens to be longer than a line. */
>
>
> then you should convert it to full winged-style, rather than just
> sticking '*' on the front of the second line.
> * All the big block comments look crowded and cramped now, which
> makes them harder to read and maintain. All those '*'s are just
> visual noise. (They make a bit more sense in C code to distinguish
> comment from code, but asm code looks so different from comment
> that they're not necessary here.)
>
> But Ingo's already pulled it, so I guess I'm stuck with it.
i pulled it and i already fixed all the proper winged style comments as
well. Could you double-check the end result please?
Ingo
next prev parent reply other threads:[~2009-02-05 17:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 1:42 [PATCH 2/3] xen: make direct versions of irq_enable/disable/save/restore to common code Jeremy Fitzhardinge
2009-01-31 1:42 ` Jeremy Fitzhardinge
2009-02-05 6:31 ` Tejun Heo
2009-02-05 15:00 ` Ingo Molnar
2009-02-05 15:00 ` Ingo Molnar
2009-02-05 15:24 ` Booting up the most recent 2.6.29-rc3 (pv_ops Dom0 support) under Xen Unstable on Intel SATA (AHCI) box Boris Derzhavets
2009-02-05 17:13 ` Boris Derzhavets
2009-02-06 6:31 ` Boris Derzhavets
2009-02-06 6:54 ` Jeremy Fitzhardinge
2009-02-06 12:01 ` Boris Derzhavets
2009-02-06 16:57 ` Jeremy Fitzhardinge
2009-02-06 19:49 ` Boris Derzhavets
2009-02-06 20:08 ` Boris Derzhavets
2009-02-07 9:48 ` Boris Derzhavets
2009-02-05 16:04 ` [PATCH] x86: style fascism for xen assemblies Tejun Heo
2009-02-05 16:57 ` Ingo Molnar
2009-02-05 16:57 ` Ingo Molnar
2009-02-05 17:31 ` Jeremy Fitzhardinge
2009-02-05 17:31 ` Jeremy Fitzhardinge
2009-02-05 17:34 ` Ingo Molnar [this message]
2009-02-05 17:34 ` Ingo Molnar
2009-02-05 17:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205173430.GA9233@elte.hu \
--to=mingo@elte.hu \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=htejun@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.