All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Lowengrub <lowdanie@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.28 1/2] memory: improve find_vma
Date: Thu, 5 Feb 2009 20:41:25 +0100	[thread overview]
Message-ID: <20090205194125.GA3129@elte.hu> (raw)
In-Reply-To: <8c5a844a0902050326v2155dbeaq5449f1e373f4245d@mail.gmail.com>


* Daniel Lowengrub <lowdanie@gmail.com> wrote:

> On Sun, Feb 1, 2009 at 3:00 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> >  you should time it:
> >
> >  time ./mmap-perf
> >
> > and compare the before/after results.
> >
> >        Ingo
> >
> 
> I made a script that runs 'time ./mmap-perf' 100 times and outputs the
> average.  The output on the standard kernel was:
>
>  real: 1.022600
>  user: 0.135900
>  system: 0.852600
>
> The output after the patch was:
>
>  real: 0.815400
>  user: 0.113200
>  system: 0.622200
>
> These results were consistent which isn't surprising considering the
> fact that they themselves are averages.
> What do you think?

Those nymbers look very convincing to me, a cool 25.4% speedup!
mmap-perf is very MM intense - including vma lookup.

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Lowengrub <lowdanie@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.28 1/2] memory: improve find_vma
Date: Thu, 5 Feb 2009 20:41:25 +0100	[thread overview]
Message-ID: <20090205194125.GA3129@elte.hu> (raw)
In-Reply-To: <8c5a844a0902050326v2155dbeaq5449f1e373f4245d@mail.gmail.com>


* Daniel Lowengrub <lowdanie@gmail.com> wrote:

> On Sun, Feb 1, 2009 at 3:00 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> >  you should time it:
> >
> >  time ./mmap-perf
> >
> > and compare the before/after results.
> >
> >        Ingo
> >
> 
> I made a script that runs 'time ./mmap-perf' 100 times and outputs the
> average.  The output on the standard kernel was:
>
>  real: 1.022600
>  user: 0.135900
>  system: 0.852600
>
> The output after the patch was:
>
>  real: 0.815400
>  user: 0.113200
>  system: 0.622200
>
> These results were consistent which isn't surprising considering the
> fact that they themselves are averages.
> What do you think?

Those nymbers look very convincing to me, a cool 25.4% speedup!
mmap-perf is very MM intense - including vma lookup.

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-02-05 19:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 16:51 [PATCH 2.6.28 1/2] memory: improve find_vma Daniel Lowengrub
2009-01-22 17:22 ` Hugh Dickins
2009-01-22 17:22   ` Hugh Dickins
2009-01-22 23:00   ` Daniel Lowengrub
2009-01-22 23:00     ` Daniel Lowengrub
2009-01-22 23:13     ` Ingo Molnar
2009-01-22 23:13       ` Ingo Molnar
2009-01-23 11:10       ` Daniel Lowengrub
2009-01-23 11:10         ` Daniel Lowengrub
2009-01-28 21:31         ` Daniel Lowengrub
2009-01-28 21:31           ` Daniel Lowengrub
2009-01-29 14:19           ` Ingo Molnar
2009-01-29 14:19             ` Ingo Molnar
2009-02-01 11:19             ` Daniel Lowengrub
2009-02-01 11:19               ` Daniel Lowengrub
2009-02-01 13:00               ` Ingo Molnar
2009-02-01 13:00                 ` Ingo Molnar
2009-02-05 11:26                 ` Daniel Lowengrub
2009-02-05 11:26                   ` Daniel Lowengrub
2009-02-05 19:41                   ` Ingo Molnar [this message]
2009-02-05 19:41                     ` Ingo Molnar
2009-02-05 19:51                     ` Peter Zijlstra
2009-02-05 19:51                       ` Peter Zijlstra
  -- strict thread matches above, loose matches on Subject: below --
2009-01-17 17:12 Daniel Lowengrub
2009-01-18 22:36 ` KOSAKI Motohiro
2009-01-20 16:26   ` Daniel Lowengrub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090205194125.GA3129@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lowdanie@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.