From: wli@movementarian.org
To: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: pud_bad vs pud_bad
Date: Thu, 5 Feb 2009 15:56:06 -0500 [thread overview]
Message-ID: <20090205205606.GG10229@movementarian.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0902052013230.12955@blonde.anvils>
On Thu, 5 Feb 2009, wli@movementarian.org wrote:
>> The RW bit needs to be allowed to become read-only for hugetlb COW.
>> Changing it over to the 32-bit method is a bugfix by that token.
On Thu, Feb 05, 2009 at 08:14:42PM +0000, Hugh Dickins wrote:
> If there's a bugfix to be made there, of course I'm in favour:
> but how come we've never seen such a bug? hugetlb COW has been
> around for a year or two by now, hasn't it?
We can tell from the code that a write-protected pte mapping of a
1GB hugetlb page would be flagged as bad. It must not be called on
ptes mapping hugetlb pages if they're not getting flagged.
-- wli
WARNING: multiple messages have this Message-ID (diff)
From: wli@movementarian.org
To: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: pud_bad vs pud_bad
Date: Thu, 5 Feb 2009 15:56:06 -0500 [thread overview]
Message-ID: <20090205205606.GG10229@movementarian.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0902052013230.12955@blonde.anvils>
On Thu, 5 Feb 2009, wli@movementarian.org wrote:
>> The RW bit needs to be allowed to become read-only for hugetlb COW.
>> Changing it over to the 32-bit method is a bugfix by that token.
On Thu, Feb 05, 2009 at 08:14:42PM +0000, Hugh Dickins wrote:
> If there's a bugfix to be made there, of course I'm in favour:
> but how come we've never seen such a bug? hugetlb COW has been
> around for a year or two by now, hasn't it?
We can tell from the code that a write-protected pte mapping of a
1GB hugetlb page would be flagged as bad. It must not be called on
ptes mapping hugetlb pages if they're not getting flagged.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-05 20:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 18:23 pud_bad vs pud_bad Jeremy Fitzhardinge
2009-02-05 18:23 ` Jeremy Fitzhardinge
2009-02-05 18:43 ` Ingo Molnar
2009-02-05 18:43 ` Ingo Molnar
2009-02-05 18:54 ` Jeremy Fitzhardinge
2009-02-05 18:54 ` Jeremy Fitzhardinge
2009-02-05 19:10 ` Ingo Molnar
2009-02-05 19:10 ` Ingo Molnar
2009-02-05 19:26 ` Jeremy Fitzhardinge
2009-02-05 19:26 ` Jeremy Fitzhardinge
2009-02-05 19:31 ` Ingo Molnar
2009-02-05 19:31 ` Ingo Molnar
2009-02-05 19:38 ` Hugh Dickins
2009-02-05 19:38 ` Hugh Dickins
2009-02-05 19:49 ` Ingo Molnar
2009-02-05 19:49 ` Ingo Molnar
2009-02-05 19:58 ` wli
2009-02-05 19:58 ` wli
2009-02-05 20:14 ` Hugh Dickins
2009-02-05 20:14 ` Hugh Dickins
2009-02-05 20:56 ` wli [this message]
2009-02-05 20:56 ` wli
2009-02-05 21:09 ` Hugh Dickins
2009-02-05 21:09 ` Hugh Dickins
2009-02-05 20:12 ` Hugh Dickins
2009-02-05 20:12 ` Hugh Dickins
2009-02-05 20:42 ` Jeremy Fitzhardinge
2009-02-05 20:42 ` Jeremy Fitzhardinge
2009-02-05 20:51 ` Hugh Dickins
2009-02-05 20:51 ` Hugh Dickins
2009-02-05 21:05 ` Jeremy Fitzhardinge
2009-02-05 21:05 ` Jeremy Fitzhardinge
2009-02-05 21:50 ` Ingo Molnar
2009-02-05 21:50 ` Ingo Molnar
2009-02-05 22:07 ` Jeremy Fitzhardinge
2009-02-05 22:07 ` Jeremy Fitzhardinge
2009-02-05 23:42 ` Ingo Molnar
2009-02-05 23:42 ` Ingo Molnar
2009-02-06 0:08 ` Jeremy Fitzhardinge
2009-02-06 0:08 ` Jeremy Fitzhardinge
2009-02-06 0:50 ` Ingo Molnar
2009-02-06 0:50 ` Ingo Molnar
2009-02-05 20:57 ` Ingo Molnar
2009-02-05 20:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205205606.GG10229@movementarian.org \
--to=wli@movementarian.org \
--cc=hugh@veritas.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.