Re: [PATCH 2/3] ide: add at91_ide driver

[Stanislaw Gruszka <stf_xl@wp.pl>]

Thursday 05 February 2009 17:09:06 Sergei Shtylyov napisał(a):
> > If you take a look at arch/arm/mach-at91/*_devices.c files, 
> > IORESOURCE_IRQ are used for interrupts from devices that are integrated
> > on the chip. Board specific irq pins (like in at91_cf, at91_ether) are not
> > passed to platform driver via platform_resource but via board data.
> 
>     I don't care what the particular broken ARM platfrom code does. If it 
> can't pass resources in a normal way, it should be fixed, and not followed as 
> a good example.
So fix these divers, then I will have no bad examples. I'll stay with board->irq_pin
for now, moving to platform_resource could be done in separate patch (maybe
with at91_cf and at91_ether).

Cheers
Stanislaw Gruszka