Re: [PATCH 2/3] ide: add at91_ide driver

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Bartlomiej Zolnierkiewicz wrote:

>>> +void at91_ide_tf_load(ide_drive_t *drive, ide_task_t *task)
>>> +{
>>> +	ide_hwif_t *hwif = drive->hwif;
>>> +	struct ide_io_ports *io_ports = &hwif->io_ports;
>>> +	struct ide_taskfile *tf = &task->tf;
>>> +	u8 HIHI = (task->tf_flags & IDE_TFLAG_LBA48) ? 0xE0 : 0xEF;
>>> +
>>> +	if (task->tf_flags & IDE_TFLAG_FLAGGED)
>>> +		HIHI = 0xFF;
>>> +
>>> +	if (task->tf_flags & IDE_TFLAG_OUT_DATA) {
>>>   
>>>       
>>    Sigh. Bart, couldn't we drop that stupid flag? I bet nobody ever used it.
>>     
>
> It is there for HDIO_DRIVE_TASKFILE ioctl and I prefer not to break it.
>
> Just add ->{read,write}_data methods for IDE_TFLAG_{IN,OUT}_DATA to struct
> ide_tp_ops -- it should also help some other host drivers like tx493*.
>   

  That would be extremely senseless activity sicne I believe this flag 
is totally useless. I have better thing to do. :-)

> Thanks,
> Bart

MBR, Sergei