From: Robin Holt <holt@sgi.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Robin Holt <holt@sgi.com>,
linux-mm@kvack.org, Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm_count.
Date: Fri, 6 Feb 2009 06:58:45 -0600 [thread overview]
Message-ID: <20090206125845.GC8559@sgi.com> (raw)
In-Reply-To: <20090206014400.GM14011@random.random>
On Fri, Feb 06, 2009 at 02:44:00AM +0100, Andrea Arcangeli wrote:
> simply. For a moment I thought unregister wasn't mandatory because at
> some point in one of the dozen versions of the api it wasn't, but in
You are right, I am remembering an older version of the API (which I
still like better, obviously ;) ). I also see the problems each choice
of API can cause. I think the current API is the more reasonable
choice. I have adjusted XPMEM to keep a copy of the mm_struct pointer
at register time with my own accompanying inc of mm_count and likewise
do the unregister and mmdrop(); This resolved my problem.
Sorry for the noise.
Andrew, could you throw this patch as away as quickly as possible.
Sorry for wasting your time.
Thanks,
Robin
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Robin Holt <holt@sgi.com>,
linux-mm@kvack.org, Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm_count.
Date: Fri, 6 Feb 2009 06:58:45 -0600 [thread overview]
Message-ID: <20090206125845.GC8559@sgi.com> (raw)
In-Reply-To: <20090206014400.GM14011@random.random>
On Fri, Feb 06, 2009 at 02:44:00AM +0100, Andrea Arcangeli wrote:
> simply. For a moment I thought unregister wasn't mandatory because at
> some point in one of the dozen versions of the api it wasn't, but in
You are right, I am remembering an older version of the API (which I
still like better, obviously ;) ). I also see the problems each choice
of API can cause. I think the current API is the more reasonable
choice. I have adjusted XPMEM to keep a copy of the mm_struct pointer
at register time with my own accompanying inc of mm_count and likewise
do the unregister and mmdrop(); This resolved my problem.
Sorry for the noise.
Andrew, could you throw this patch as away as quickly as possible.
Sorry for wasting your time.
Thanks,
Robin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-06 12:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:23 [Patch] mmu_notifiers destroyed by __mmu_notifier_release() retain extra mm_count Robin Holt
2009-02-05 17:23 ` Robin Holt
2009-02-05 19:30 ` Christoph Lameter
2009-02-05 19:30 ` Christoph Lameter
2009-02-05 20:02 ` Robin Holt
2009-02-05 20:02 ` Robin Holt
2009-02-05 23:54 ` Christoph Lameter
2009-02-05 23:54 ` Christoph Lameter
2009-02-06 1:38 ` Andrea Arcangeli
2009-02-06 1:38 ` Andrea Arcangeli
2009-02-06 1:44 ` Andrea Arcangeli
2009-02-06 1:44 ` Andrea Arcangeli
2009-02-06 12:58 ` Robin Holt [this message]
2009-02-06 12:58 ` Robin Holt
2009-02-06 16:56 ` Andrea Arcangeli
2009-02-06 16:56 ` Andrea Arcangeli
2009-02-05 21:20 ` Andrea Arcangeli
2009-02-05 21:20 ` Andrea Arcangeli
2009-02-05 22:25 ` Andrew Morton
2009-02-05 22:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206125845.GC8559@sgi.com \
--to=holt@sgi.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.