All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: sam@ravnborg.org, akpm@osdl.org, albcamus@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tags: fix config symbols generation
Date: Fri, 6 Feb 2009 07:08:58 -0800	[thread overview]
Message-ID: <20090206150858.GA15565@padd.com> (raw)
In-Reply-To: <20090129102618.GB4425@x200.localdomain>

adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> breaks tags generation for Kconfig symbols.
> 
> Steps to reproduce:
> 
> 	make tags
> 	vi -t PROC_FS
> 
> It should jump to 'config PROC_FS' line.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  scripts/tags.sh |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -76,7 +76,10 @@ all_sources()
>  
>  all_kconfigs()
>  {
> -	find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> +	for arch in $ALLSOURCE_ARCHS; do
> +		find_sources $arch 'Kconfig*'
> +	done
> +	find_other_sources 'Kconfig*'
>  }
>  
>  all_defconfigs()

Yes, this is necessary.  It fixes the problem introduced by
4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
ALLSOURCE_ARCHS support for tags/cscope).

Tested-by: Pete Wyckoff <pw@padd.com>


  reply	other threads:[~2009-02-06 15:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29 10:26 [PATCH] tags: fix config symbols generation Alexey Dobriyan
2009-02-06 15:08 ` Pete Wyckoff [this message]
2009-02-06 17:22   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090206150858.GA15565@padd.com \
    --to=pw@padd.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=albcamus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.