From: "Uwe Kleine-König" <ukleinek-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>
To: Frank Seidel <fseidel-l3A5Bk7waGM@public.gmane.org>
Cc: linux kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
frank-aMRDT+nbkrEb1SvskN2V4Q@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Frans Pop <elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>,
Geert Uytterhoeven
<Geert.Uytterhoeven-osDt5Q4Chk1BDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks
Date: Fri, 6 Feb 2009 21:53:54 +0100 [thread overview]
Message-ID: <20090206205354.GA7400@strlen.de> (raw)
In-Reply-To: <498C96B0.7050408-l3A5Bk7waGM@public.gmane.org>
Hallo Frank,
On Fri, Feb 06, 2009 at 08:59:44PM +0100, Frank Seidel wrote:
> Uwe Kleine-König schrieb:
> > Are you sure about KERN_WARNING? I havn't looked deeper, but DEB2
> > suggests KERN_DEBUG? What about fixing DEB[1-3] directly instead of
> > each "call". e.g.
>
> No, in this case the DEB* macro was already in many places used
> with KERN_* constants just like direct printk. I didn't wanna
> change that.
> KERN_WARNING is just the standard/default loglevel so that this
> change doesn't introduce different behaviour.
Ah, OK. Then you have my Acked-by.
Best regards
Uwe
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <ukleinek@strlen.de>
To: Frank Seidel <fseidel@suse.de>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, khali@linux-fr.org,
ben-linux@fluff.org, linux-i2c@vger.kernel.org,
frank@f-seidel.de, w.sang@pengutronix.de,
"David S. Miller" <davem@davemloft.net>,
Frans Pop <elendil@planet.nl>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: Re: [PATCH] i2c: add missing KERN_* constants to printks
Date: Fri, 6 Feb 2009 21:53:54 +0100 [thread overview]
Message-ID: <20090206205354.GA7400@strlen.de> (raw)
In-Reply-To: <498C96B0.7050408@suse.de>
Hallo Frank,
On Fri, Feb 06, 2009 at 08:59:44PM +0100, Frank Seidel wrote:
> Uwe Kleine-König schrieb:
> > Are you sure about KERN_WARNING? I havn't looked deeper, but DEB2
> > suggests KERN_DEBUG? What about fixing DEB[1-3] directly instead of
> > each "call". e.g.
>
> No, in this case the DEB* macro was already in many places used
> with KERN_* constants just like direct printk. I didn't wanna
> change that.
> KERN_WARNING is just the standard/default loglevel so that this
> change doesn't introduce different behaviour.
Ah, OK. Then you have my Acked-by.
Best regards
Uwe
next prev parent reply other threads:[~2009-02-06 20:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 13:45 [PATCH] i2c: add missing KERN_* constants to printks Frank Seidel
2009-02-06 13:45 ` Frank Seidel
[not found] ` <498C3EEA.5060508-l3A5Bk7waGM@public.gmane.org>
2009-02-06 18:35 ` Uwe Kleine-König
2009-02-06 18:35 ` Uwe Kleine-König
[not found] ` <20090206183542.GB6361-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>
2009-02-06 19:59 ` Frank Seidel
2009-02-06 19:59 ` Frank Seidel
[not found] ` <498C96B0.7050408-l3A5Bk7waGM@public.gmane.org>
2009-02-06 20:53 ` Uwe Kleine-König [this message]
2009-02-06 20:53 ` Uwe Kleine-König
2009-02-06 21:23 ` Jean Delvare
2009-02-06 21:23 ` Jean Delvare
[not found] ` <20090206222314.6c2b36f7-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-07 10:37 ` Frank Seidel
2009-02-07 10:37 ` Frank Seidel
[not found] ` <498D647C.8070107-l3A5Bk7waGM@public.gmane.org>
2009-02-07 10:52 ` Uwe Kleine-König
2009-02-07 10:52 ` Uwe Kleine-König
[not found] ` <20090207105219.GA12371-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>
2009-02-07 15:58 ` Jean Delvare
2009-02-07 15:58 ` Jean Delvare
2009-02-07 23:05 ` Jean Delvare
2009-02-07 23:05 ` Jean Delvare
2009-02-08 13:11 ` Frank Seidel
[not found] ` <498EDA18.1090300-aMRDT+nbkrEb1SvskN2V4Q@public.gmane.org>
2009-02-08 13:47 ` Jean Delvare
2009-02-08 13:47 ` Jean Delvare
[not found] ` <20090208144751.46184041-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-02-08 14:16 ` Frank Seidel
2009-02-08 14:16 ` Frank Seidel
2009-02-09 8:35 ` Wolfram Sang
2009-02-09 8:35 ` Wolfram Sang
[not found] ` <20090209083537.GA3438-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-02-09 10:27 ` Jean Delvare
2009-02-09 10:27 ` Jean Delvare
2009-02-08 14:18 ` [PATCHv2 1/2] " Frank Seidel
2009-02-08 14:18 ` Frank Seidel
[not found] ` <498EE9C9.4080002-l3A5Bk7waGM@public.gmane.org>
2009-02-08 14:20 ` [PATCHv2 2/2] i2c: adapt debug macros for KERN_* constants Frank Seidel
2009-02-08 14:20 ` Frank Seidel
[not found] ` <498EEA2F.5050601-l3A5Bk7waGM@public.gmane.org>
2009-02-09 15:16 ` Jean Delvare
2009-02-09 15:16 ` Jean Delvare
2009-02-10 15:16 ` Wolfram Sang
2009-02-21 12:39 ` Wolfram Sang
2009-02-09 12:22 ` [PATCHv2 1/2] i2c: add missing KERN_* constants to printks Jean Delvare
2009-02-09 12:22 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090206205354.GA7400@strlen.de \
--to=ukleinek-hffvjypymkqzqb+pc5nmwq@public.gmane.org \
--cc=Geert.Uytterhoeven-osDt5Q4Chk1BDgjK7y7TUQ@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org \
--cc=frank-aMRDT+nbkrEb1SvskN2V4Q@public.gmane.org \
--cc=fseidel-l3A5Bk7waGM@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.