From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Rafael Garcia-Suarez" <rgarciasuarez@gmail.com>,
git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Toralf Förster" <toralf.foerster@gmx.de>
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Date: Sat, 7 Feb 2009 10:25:01 +0100 [thread overview]
Message-ID: <200902071025.02491.jnareb@gmail.com> (raw)
In-Reply-To: <7v7i42y6ms.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > It would unfortunately falsely match... but we cannot eliminate this
> > case (well, at least not checking if hexnumber is followed by dot),
> > because of totally legitimate
> >
> > ... at commit 8457bb9e.
> >
> > So even with that we would have still false matches...
>
> Yeah, so what's the value in v2 over v1? It is still wrong but it is less
> wrong than it used to be? I think the word-boundary one made a good
> sense. I do not see the @lookahead adding much value at all.
Right. So v2 is less useful that I thought it to be; and adding further
"exceptions" doesn't seem like a good idea. The 'msgid' committag
when/if it gets implemented would help there...
So please take v1, as it is sane improvement and generic enough.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-02-07 9:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:04 webgit highlightes mem adresses as git versions Toralf Förster
2009-02-02 22:54 ` Jakub Narebski
2009-02-03 11:04 ` Toralf Förster
2009-02-03 12:31 ` Johannes Schindelin
2009-02-06 9:12 ` [PATCH] gitweb: Better regexp for SHA-1 committag match Jakub Narebski
2009-02-06 9:49 ` Rafael Garcia-Suarez
2009-02-06 10:26 ` Jakub Narebski
2009-02-06 10:31 ` Rafael Garcia-Suarez
2009-02-06 10:49 ` [PATCHv2] " Jakub Narebski
2009-02-06 13:03 ` Johannes Schindelin
2009-02-06 21:47 ` Jay Soffian
2009-02-06 22:00 ` Jakub Narebski
2009-02-07 7:48 ` Junio C Hamano
2009-02-07 8:34 ` Jakub Narebski
2009-02-07 8:48 ` Junio C Hamano
2009-02-07 9:25 ` Jakub Narebski [this message]
2009-02-07 9:32 ` demerphq
2009-02-07 10:09 ` Jakub Narebski
2009-02-07 14:01 ` Jakub Narebski
2009-02-07 9:22 ` [PATCH] " demerphq
2009-02-07 10:07 ` Jakub Narebski
2009-02-07 13:30 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902071025.02491.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rgarciasuarez@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.