From: Jakub Narebski <jnareb@gmail.com>
To: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Cc: git@vger.kernel.org,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Toralf Förster" <toralf.foerster@gmx.de>
Subject: Re: [PATCHv2] gitweb: Better regexp for SHA-1 committag match
Date: Sat, 7 Feb 2009 15:01:31 +0100 [thread overview]
Message-ID: <200902071501.34312.jnareb@gmail.com> (raw)
In-Reply-To: <200902061149.16210.jnareb@gmail.com>
Dnia piątek 6. lutego 2009 11:49, Jakub Narebski napisał:
> + if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(!?\@)/) {
+ if ($line =~ m/\b([0-9a-fA-F]{8,40})\b(?!\@)/) {
Not that it matters, because adding such single-case exceptions
is not a good idea, so it is v1 which would be (I hope) in git.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2009-02-07 14:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 21:04 webgit highlightes mem adresses as git versions Toralf Förster
2009-02-02 22:54 ` Jakub Narebski
2009-02-03 11:04 ` Toralf Förster
2009-02-03 12:31 ` Johannes Schindelin
2009-02-06 9:12 ` [PATCH] gitweb: Better regexp for SHA-1 committag match Jakub Narebski
2009-02-06 9:49 ` Rafael Garcia-Suarez
2009-02-06 10:26 ` Jakub Narebski
2009-02-06 10:31 ` Rafael Garcia-Suarez
2009-02-06 10:49 ` [PATCHv2] " Jakub Narebski
2009-02-06 13:03 ` Johannes Schindelin
2009-02-06 21:47 ` Jay Soffian
2009-02-06 22:00 ` Jakub Narebski
2009-02-07 7:48 ` Junio C Hamano
2009-02-07 8:34 ` Jakub Narebski
2009-02-07 8:48 ` Junio C Hamano
2009-02-07 9:25 ` Jakub Narebski
2009-02-07 9:32 ` demerphq
2009-02-07 10:09 ` Jakub Narebski
2009-02-07 14:01 ` Jakub Narebski [this message]
2009-02-07 9:22 ` [PATCH] " demerphq
2009-02-07 10:07 ` Jakub Narebski
2009-02-07 13:30 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902071501.34312.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=rgarciasuarez@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.