From: Matthew Wilcox <matthew@wil.cx>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Ingo Molnar <mingo@elte.hu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/irq: fix sparse warning: make symbol static
Date: Sun, 08 Feb 2009 23:09:10 +0000 [thread overview]
Message-ID: <20090208230910.GH31509@parisc-linux.org> (raw)
In-Reply-To: <20090208192405.8084.89231.stgit@vmbox.hanneseder.net>
On Sun, Feb 08, 2009 at 08:24:47PM +0100, Hannes Eder wrote:
> -static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)
> +static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
Does this not introduce a checkpatch warning about a line being longer
than 80 columns? Three acceptable ways to fix this:
static inline
int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
static inline int do_irq_select_affinity(unsigned int irq,
struct irq_desc *desc)
static inline int do_irq_select_affinity(unsigned irq, struct irq_desc *desc)
My favourite is the last one.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Ingo Molnar <mingo@elte.hu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/irq: fix sparse warning: make symbol static
Date: Sun, 8 Feb 2009 16:09:10 -0700 [thread overview]
Message-ID: <20090208230910.GH31509@parisc-linux.org> (raw)
In-Reply-To: <20090208192405.8084.89231.stgit@vmbox.hanneseder.net>
On Sun, Feb 08, 2009 at 08:24:47PM +0100, Hannes Eder wrote:
> -static inline int do_irq_select_affinity(int irq, struct irq_desc *desc)
> +static inline int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
Does this not introduce a checkpatch warning about a line being longer
than 80 columns? Three acceptable ways to fix this:
static inline
int do_irq_select_affinity(unsigned int irq, struct irq_desc *desc)
static inline int do_irq_select_affinity(unsigned int irq,
struct irq_desc *desc)
static inline int do_irq_select_affinity(unsigned irq, struct irq_desc *desc)
My favourite is the last one.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-02-08 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 19:24 [PATCH] kernel/irq: fix sparse warning: make symbol static Hannes Eder
2009-02-08 19:24 ` Hannes Eder
2009-02-08 23:09 ` Matthew Wilcox [this message]
2009-02-08 23:09 ` Matthew Wilcox
2009-02-09 9:16 ` Ingo Molnar
2009-02-09 9:16 ` Ingo Molnar
2009-02-09 10:36 ` Hannes Eder
2009-02-09 10:36 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090208230910.GH31509@parisc-linux.org \
--to=matthew@wil.cx \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.