From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Borislav Petkov <petkovbb@gmail.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/6] ide: more unifications of ATA and ATAPI support
Date: Tue, 10 Feb 2009 00:19:45 +0100 [thread overview]
Message-ID: <20090209231945.32406.14874.sendpatchset@localhost.localdomain> (raw)
After this patchset we have a valid struct ide_cmd available also for
ATA_CMD_PACKET commands and comparing struct ide_atapi_pc with ide_cmd it
seems that there are many similarities between them and that we may just
merge both structs (this should also allow us to unify ide-cd code with
non-ide-cd one in ide-atapi.c later). From the quick look the only gotcha
is REQUEST SENSE handling, ->request_sense_pc needs to be converted to
->request_sense_cmd and we have to be careful with choosing right 'cmd'
in *_issue_pc()...
Borislav, please take a look and tell me what do you think about it
(also feel free to go ahead with patches :-)...
On top of "[PATCH 0/9] ide: unify request completion methods" patchset
[ http://lkml.org/lkml/2009/2/9/398 ].
diffstat:
drivers/ide/alim15x3.c | 9 ++---
drivers/ide/au1xxx-ide.c | 23 +++----------
drivers/ide/cmd64x.c | 6 +--
drivers/ide/cs5536.c | 2 -
drivers/ide/hpt366.c | 6 +--
drivers/ide/icside.c | 14 +-------
drivers/ide/ide-atapi.c | 77 +++++++++++++++++++++------------------------
drivers/ide/ide-cd.c | 14 +++++++-
drivers/ide/ide-disk.c | 14 ++++----
drivers/ide/ide-dma-sff.c | 33 +++++++------------
drivers/ide/ide-dma.c | 16 ++++-----
drivers/ide/ide-eh.c | 9 ++---
drivers/ide/ide-floppy.c | 32 +++++++++++-------
drivers/ide/ide-io.c | 14 ++++----
drivers/ide/ide-iops.c | 42 ++++++++----------------
drivers/ide/ide-tape.c | 19 ++++++++---
drivers/ide/ide-taskfile.c | 57 ++++++++++++++++-----------------
drivers/ide/it821x.c | 2 -
drivers/ide/ns87415.c | 6 +--
drivers/ide/pdc202xx_old.c | 4 +-
drivers/ide/pmac.c | 27 ++++-----------
drivers/ide/sc1200.c | 2 -
drivers/ide/scc_pata.c | 21 ++++--------
drivers/ide/sgiioc4.c | 21 ++++--------
drivers/ide/siimage.c | 2 -
drivers/ide/sl82c105.c | 2 -
drivers/ide/tc86c001.c | 2 -
drivers/ide/trm290.c | 16 ++-------
drivers/ide/tx4939ide.c | 28 ++++++----------
include/linux/ide.h | 36 +++++++++------------
30 files changed, 251 insertions(+), 305 deletions(-)
next reply other threads:[~2009-02-09 23:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 23:19 Bartlomiej Zolnierkiewicz [this message]
2009-02-09 23:19 ` [PATCH 1/6] ide: pass command to ide_map_sg() Bartlomiej Zolnierkiewicz
2009-02-11 6:36 ` Borislav Petkov
2009-02-11 16:28 ` Bartlomiej Zolnierkiewicz
2009-02-09 23:19 ` [PATCH 2/6] ide: use do_rw_taskfile() for ATA_CMD_PACKET commands Bartlomiej Zolnierkiewicz
2009-02-09 23:20 ` [PATCH 3/6] ide: set hwif->expiry prior to calling [__]ide_set_handler() Bartlomiej Zolnierkiewicz
2009-03-16 14:23 ` Sergei Shtylyov
2009-02-09 23:20 ` [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmd one Bartlomiej Zolnierkiewicz
2009-02-10 18:18 ` Sergei Shtylyov
2009-02-11 16:30 ` Bartlomiej Zolnierkiewicz
2009-02-11 17:30 ` Sergei Shtylyov
2009-02-17 14:16 ` Bartlomiej Zolnierkiewicz
2009-02-17 14:29 ` Sergei Shtylyov
2009-02-09 23:20 ` [PATCH 5/6] ide: remove ide_execute_pkt_cmd() Bartlomiej Zolnierkiewicz
2009-02-11 6:55 ` Borislav Petkov
2009-02-11 13:22 ` Sergei Shtylyov
2009-02-11 13:37 ` Borislav Petkov
2009-02-11 13:49 ` Sergei Shtylyov
2009-02-11 16:32 ` Borislav Petkov
2009-02-15 12:24 ` Sergei Shtylyov
2009-02-15 17:39 ` Borislav Petkov
2009-02-15 23:18 ` Sergei Shtylyov
2009-02-16 8:56 ` Borislav Petkov
2009-02-11 16:37 ` Bartlomiej Zolnierkiewicz
2009-02-09 23:20 ` [PATCH 6/6] ide: keep track of number of bytes instead of sectors in struct ide_cmd Bartlomiej Zolnierkiewicz
2009-02-11 7:16 ` [PATCH 0/6] ide: more unifications of ATA and ATAPI support Borislav Petkov
2009-02-23 22:51 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209231945.32406.14874.sendpatchset@localhost.localdomain \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.