From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Alex Chiang <achiang@hp.com>,
tony.luck@intel.com, stable@kernel.org,
linux-ia64@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] ia64: prevent irq migration race in
Date: Tue, 10 Feb 2009 12:36:46 +0000 [thread overview]
Message-ID: <20090210123645.GA7542@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090209181338.GD19064@ldl.fc.hp.com>
On Mon, Feb 09, 2009 at 11:13:38AM -0700, Alex Chiang wrote:
> This is v2 of my attempt to prevent an oops while offlining CPUs.
>
> The change is that the patch becomes a full revert of Paul's
> original patch, along with a long changelog that explains the
> situation as best as I can determine. It's not 100% satisfactory
> to me right now, but the testing we've done supports the patch.
>
> The 2nd patch in the series is mostly cosmetic, and removes a
> redundant call to cpu_clear() that we no longer need().
>
> Tony, if you agree with the rationale in 1/2, then this series is
> a candidate for .29.
>
> stable team, if Tony pushes upstream for .29, then this series
> should be applied to the .27 and .28 stable series.
OK, I'll bite...
Why not use cpu_active_map rather than cpu_online_map to select which
CPU to migrate interrupts to? That way, we can delay clearing the
bit in cpu_online_map and avoid the questionable scenario where irqs
are being handled by a CPU that appears to be offline.
Thanx, Paul
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Alex Chiang <achiang@hp.com>,
tony.luck@intel.com, stable@kernel.org,
linux-ia64@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable path
Date: Tue, 10 Feb 2009 04:36:46 -0800 [thread overview]
Message-ID: <20090210123645.GA7542@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090209181338.GD19064@ldl.fc.hp.com>
On Mon, Feb 09, 2009 at 11:13:38AM -0700, Alex Chiang wrote:
> This is v2 of my attempt to prevent an oops while offlining CPUs.
>
> The change is that the patch becomes a full revert of Paul's
> original patch, along with a long changelog that explains the
> situation as best as I can determine. It's not 100% satisfactory
> to me right now, but the testing we've done supports the patch.
>
> The 2nd patch in the series is mostly cosmetic, and removes a
> redundant call to cpu_clear() that we no longer need().
>
> Tony, if you agree with the rationale in 1/2, then this series is
> a candidate for .29.
>
> stable team, if Tony pushes upstream for .29, then this series
> should be applied to the .27 and .28 stable series.
OK, I'll bite...
Why not use cpu_active_map rather than cpu_online_map to select which
CPU to migrate interrupts to? That way, we can delay clearing the
bit in cpu_online_map and avoid the questionable scenario where irqs
are being handled by a CPU that appears to be offline.
Thanx, Paul
next prev parent reply other threads:[~2009-02-10 12:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 18:13 [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable Alex Chiang
2009-02-09 18:13 ` [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable path Alex Chiang
2009-02-09 18:16 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq Alex Chiang
2009-02-09 18:16 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq handlers on offline CPUs" Alex Chiang
2009-02-09 21:17 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq Alex Chiang
2009-02-09 21:17 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq handlers on offline CPUs" Alex Chiang
2009-02-09 23:33 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq Alex Chiang
2009-02-09 23:33 ` [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq handlers on offline CPUs" Alex Chiang
2009-02-09 23:52 ` Russ Anderson
2009-02-09 23:52 ` Russ Anderson
2009-11-12 22:40 ` [APPLIED] [PATCH v2 1/2] Revert "[IA64] prevent ia64 from invoking irq Tony Lindgren
2009-02-09 18:16 ` [PATCH v2 2/2] ia64: Remove redundant cpu_clear() in __cpu_disable Alex Chiang
2009-02-09 18:16 ` [PATCH v2 2/2] ia64: Remove redundant cpu_clear() in __cpu_disable path Alex Chiang
2009-02-10 12:36 ` Paul E. McKenney [this message]
2009-02-10 12:36 ` [PATCH v2 0/2] ia64: prevent irq migration race " Paul E. McKenney
2009-02-10 16:11 ` [PATCH v2 0/2] ia64: prevent irq migration race in Alex Chiang
2009-02-10 16:11 ` [PATCH v2 0/2] ia64: prevent irq migration race in __cpu_disable path Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210123645.GA7542@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=achiang@hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.