From: Dean Nelson <dcn@sgi.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Tony Luck <tony.luck@intel.com>
Cc: Jack Steiner <steiner@sgi.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ia64 <linux-ia64@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] don't compile SGI XP/GRU on ia64_generic
Date: Tue, 10 Feb 2009 13:38:21 +0000 [thread overview]
Message-ID: <20090210133821.GA23973@sgi.com> (raw)
In-Reply-To: <20090210162821.6FC1.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Tue, Feb 10, 2009 at 04:35:46PM +0900, KOSAKI Motohiro wrote:
> Impact: fix build error
>
> Currently sgi-xp driver depend on "uv.h" header file.
> but only x86 have "uv.h" header.
Yesterday I submitted a patch that introduces a 'uv.h' header file for
ia64 and eliminates the ia64 build error. Link to any one of the following
to see the patch.
http://marc.info/?l=linux-ia64&m\x123419673126499&w=2
http://marc.info/?l=linux-next&m\x123419673226503&w=2
http://marc.info/?l=linux-kernel&m\x123419682026636&w=2
That is the preferred solution to this problem.
> Then, ia64 hit following build error.
>
> In file included from drivers/misc/sgi-gru/grufile.c:39:
> drivers/misc/sgi-gru/gru.h:22:23: error: asm/uv/uv.h: No such file or directory
>
> Cc: Jack Steiner <steiner@sgi.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> ---
> drivers/misc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/misc/Kconfig
> =================================> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -165,7 +165,7 @@ config SGI_XP
> depends on (IA64_GENERIC || IA64_SGI_SN2 || IA64_SGI_UV || X86_UV) && SMP
> select IA64_UNCACHED_ALLOCATOR if IA64_GENERIC || IA64_SGI_SN2
> select GENERIC_ALLOCATOR if IA64_GENERIC || IA64_SGI_SN2
> - select SGI_GRU if (IA64_GENERIC || IA64_SGI_UV || X86_64) && SMP
> + select SGI_GRU if (IA64_SGI_UV || X86_UV) && SMP
> ---help---
> An SGI machine can be divided into multiple Single System
> Images which act independently of each other and have
> @@ -189,7 +189,7 @@ config HP_ILO
>
> config SGI_GRU
> tristate "SGI GRU driver"
> - depends on (X86_UV || IA64_SGI_UV || IA64_GENERIC) && SMP
> + depends on (X86_UV || IA64_SGI_UV) && SMP
> default n
> select MMU_NOTIFIER
> ---help---
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dcn@sgi.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Tony Luck <tony.luck@intel.com>
Cc: Jack Steiner <steiner@sgi.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ia64 <linux-ia64@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] don't compile SGI XP/GRU on ia64_generic
Date: Tue, 10 Feb 2009 07:38:21 -0600 [thread overview]
Message-ID: <20090210133821.GA23973@sgi.com> (raw)
In-Reply-To: <20090210162821.6FC1.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Tue, Feb 10, 2009 at 04:35:46PM +0900, KOSAKI Motohiro wrote:
> Impact: fix build error
>
> Currently sgi-xp driver depend on "uv.h" header file.
> but only x86 have "uv.h" header.
Yesterday I submitted a patch that introduces a 'uv.h' header file for
ia64 and eliminates the ia64 build error. Link to any one of the following
to see the patch.
http://marc.info/?l=linux-ia64&m=123419673126499&w=2
http://marc.info/?l=linux-next&m=123419673226503&w=2
http://marc.info/?l=linux-kernel&m=123419682026636&w=2
That is the preferred solution to this problem.
> Then, ia64 hit following build error.
>
> In file included from drivers/misc/sgi-gru/grufile.c:39:
> drivers/misc/sgi-gru/gru.h:22:23: error: asm/uv/uv.h: No such file or directory
>
> Cc: Jack Steiner <steiner@sgi.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> ---
> drivers/misc/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/misc/Kconfig
> ===================================================================
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -165,7 +165,7 @@ config SGI_XP
> depends on (IA64_GENERIC || IA64_SGI_SN2 || IA64_SGI_UV || X86_UV) && SMP
> select IA64_UNCACHED_ALLOCATOR if IA64_GENERIC || IA64_SGI_SN2
> select GENERIC_ALLOCATOR if IA64_GENERIC || IA64_SGI_SN2
> - select SGI_GRU if (IA64_GENERIC || IA64_SGI_UV || X86_64) && SMP
> + select SGI_GRU if (IA64_SGI_UV || X86_UV) && SMP
> ---help---
> An SGI machine can be divided into multiple Single System
> Images which act independently of each other and have
> @@ -189,7 +189,7 @@ config HP_ILO
>
> config SGI_GRU
> tristate "SGI GRU driver"
> - depends on (X86_UV || IA64_SGI_UV || IA64_GENERIC) && SMP
> + depends on (X86_UV || IA64_SGI_UV) && SMP
> default n
> select MMU_NOTIFIER
> ---help---
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-10 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 7:35 [PATCH] don't compile SGI XP/GRU on ia64_generic KOSAKI Motohiro
2009-02-10 7:35 ` KOSAKI Motohiro
2009-02-10 12:03 ` [PATCH 2/2] " KOSAKI Motohiro
2009-02-10 12:03 ` KOSAKI Motohiro
2009-02-10 12:51 ` Robin Holt
2009-02-10 12:51 ` Robin Holt
2009-02-10 12:54 ` KOSAKI Motohiro
2009-02-10 12:54 ` KOSAKI Motohiro
2009-02-10 13:38 ` Dean Nelson [this message]
2009-02-10 13:38 ` [PATCH] " Dean Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210133821.GA23973@sgi.com \
--to=dcn@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.