Re: [PATCH 1/2] tracing/sysprof: add missing tracing_{start,stop}_record_cmdline()

[Frederic Weisbecker <fweisbec@gmail.com>]

On Tue, Feb 10, 2009 at 01:31:45PM +0100, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > 
> > > Add the missing pair tracing_{start,stop}_record_cmdline() to record well
> > > the cmdline associated with pid.
> > > 
> > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > > ---
> > >  kernel/trace/trace_sysprof.c |    3 +++
> > >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > applied to tip/tracing/sysprof, thanks Frederic!
> 
> hm, causes a build failure:
> 
> kernel/built-in.o: In function `stack_trace_reset':
> trace_sysprof.c:(.text+0x3e91a): undefined reference to `tracing_stop_cmdline_record'
> kernel/built-in.o: In function `stack_trace_init':
> trace_sysprof.c:(.text+0x3e953): undefined reference to `tracing_start_cmdline_record'
> 
> 	Ingo

Sorry, this fixlet solves the problem:

--
>From 97113f668e9aef7ba101fbb3399e5ebb27aeec4c Mon Sep 17 00:00:00 2001
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Tue, 10 Feb 2009 15:07:22 +0100
Subject: [PATCH] tracing/sysprof: fix a build error on sysprof tracer

Fix the following build error:

kernel/built-in.o: In function `stack_trace_reset':
trace_sysprof.c:(.text+0x3e91a): undefined reference to `tracing_stop_cmdline_record'
kernel/built-in.o: In function `stack_trace_init':
trace_sysprof.c:(.text+0x3e953): undefined reference to `tracing_start_cmdline_record'

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 kernel/trace/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 79be773..620f9cd 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -134,6 +134,7 @@ config SYSPROF_TRACER
 	bool "Sysprof Tracer"
 	depends on X86
 	select TRACING
+	select CONTEXT_SWITCH_TRACER
 	help
 	  This tracer provides the trace needed by the 'Sysprof' userspace
 	  tool.
-- 
1.6.1