Re: [PATCH 1/2] tracing/sysprof: add missing tracing_{start,stop}_record_cmdline()

[Frederic Weisbecker <fweisbec@gmail.com>]

On Tue, Feb 10, 2009 at 09:26:11AM -0500, Steven Rostedt wrote:
> 
> On Tue, 10 Feb 2009, Frederic Weisbecker wrote:
> 
> Hi Frederic!
> 
> Just a quick comment about the change log. I'm still learning how to
> write them too, but I'll give my 2 cents anyway ;-)
> 
> When looking a logs, I sometimes like to know the reason for the change.
> So below I would have also included...
> 
> > 
> > --
> > >From 97113f668e9aef7ba101fbb3399e5ebb27aeec4c Mon Sep 17 00:00:00 2001
> > From: Frederic Weisbecker <fweisbec@gmail.com>
> > Date: Tue, 10 Feb 2009 15:07:22 +0100
> > Subject: [PATCH] tracing/sysprof: fix a build error on sysprof tracer
> > 
> 
> The sysprof tracer gets the command line data from the context switch 
> tracer. We must select it otherwise we get 
> 
> >  the following build error:
> > 
> > kernel/built-in.o: In function `stack_trace_reset':
> > trace_sysprof.c:(.text+0x3e91a): undefined reference to `tracing_stop_cmdline_record'
> > kernel/built-in.o: In function `stack_trace_init':
> > trace_sysprof.c:(.text+0x3e953): undefined reference to `tracing_start_cmdline_record'
> > 
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> 
> Just makes reading the logs a bit easier to see what is happening.


Exact, you're right :-)
Anyway, I've unified it in a combo patch...

 
> Thanks!
> 
> Acked-by: Steven Rostedt <srostedt@redhat.com>
> 
> -- Steve
>