All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: zohar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	jmorris@namei.org, safford@watson.ibm.com, serue@us.ibm.com,
	zohar@us.ibm.com
Subject: Re: [PATCH] integrity: shmem zero fix
Date: Tue, 10 Feb 2009 14:34:45 -0800	[thread overview]
Message-ID: <20090210143445.40b2cc9d.akpm@linux-foundation.org> (raw)
In-Reply-To: <8bd0f97a0902091603mbab4d50id9790658c5579c15@mail.gmail.com>

On Mon, 9 Feb 2009 19:03:51 -0500
Mike Frysinger <vapier.adi@gmail.com> wrote:

> On Mon, Feb 9, 2009 at 18:02, Mimi Zohar wrote:
> > Based on comments from Mike Frysinger and Randy Dunlap,
> > - moved ima.h include before CONFIG_SHMEM test
> > - added 'struct linux_binprm' in ima.h
> 
> please move the linux/fs.h include in linux/ima.h to match
> linux_binprm location while you're at it

Please write a full changelog too.  That one didn't tell us what
was being fixed.

As it is presumably a compilation fix, please include the compiler
error messages in the changelog, along with a description of what
circumstances cause the error to occur.

Thanks.

  parent reply	other threads:[~2009-02-10 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 23:02 [PATCH] integrity: shmem zero fix Mimi Zohar
2009-02-10  0:03 ` Mike Frysinger
2009-02-10  0:10   ` Randy Dunlap
2009-02-10 22:34   ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-02-10  2:04 Mimi Zohar
2009-02-11  4:01 Mimi Zohar
2009-02-11  4:05 ` Mike Frysinger
2009-02-11  4:30   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090210143445.40b2cc9d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=safford@watson.ibm.com \
    --cc=serue@us.ibm.com \
    --cc=vapier.adi@gmail.com \
    --cc=zohar@linux.vnet.ibm.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.