From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
James Morris <jmorris@namei.org>,
David Safford <safford@watson.ibm.com>,
Serge Hallyn <serue@us.ibm.com>, Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH] integrity: shmem zero fix
Date: Mon, 09 Feb 2009 16:10:29 -0800 [thread overview]
Message-ID: <4990C5F5.2050400@oracle.com> (raw)
In-Reply-To: <8bd0f97a0902091603mbab4d50id9790658c5579c15@mail.gmail.com>
Mike Frysinger wrote:
> On Mon, Feb 9, 2009 at 18:02, Mimi Zohar wrote:
>> Based on comments from Mike Frysinger and Randy Dunlap,
>> - moved ima.h include before CONFIG_SHMEM test
>> - added 'struct linux_binprm' in ima.h
>
> please move the linux/fs.h include in linux/ima.h to match
> linux_binprm location while you're at it
Yes, that's the only difference with what I tested:
-#include <linux/fs.h>
-
#ifndef _LINUX_IMA_H
#define _LINUX_IMA_H
+#include <linux/fs.h>
+struct linux_binprm;
+
--
~Randy
next prev parent reply other threads:[~2009-02-10 0:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 23:02 [PATCH] integrity: shmem zero fix Mimi Zohar
2009-02-10 0:03 ` Mike Frysinger
2009-02-10 0:10 ` Randy Dunlap [this message]
2009-02-10 22:34 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2009-02-10 2:04 Mimi Zohar
2009-02-11 4:01 Mimi Zohar
2009-02-11 4:05 ` Mike Frysinger
2009-02-11 4:30 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4990C5F5.2050400@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=serue@us.ibm.com \
--cc=vapier.adi@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.