From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Kalle Jokiniemi
<kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>
Cc: lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jouni.hogander-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org,
broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org
Subject: Re: [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver
Date: Tue, 10 Feb 2009 23:23:30 -0800 [thread overview]
Message-ID: <200902102323.30395.david-b@pacbell.net> (raw)
In-Reply-To: <1234336002-26372-1-git-send-email-kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>
On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> These couple of patches enable dynamic swithcing of the
> regulators used by twl4030 usb tranceiver.
>
> This set replaces the single patch "USB: disable twl4030
> USB regulators when cable unplugged" sent previously.
> The change to previous version is that possible errors
> in regulator_get are now handled and the twl4030 usb
> driver requires TWL_REGULATOR support to be compiled.
It'd make more sense to me as a single patch ... :)
And also, instead of *continuing* after the regulators
can't be acquired, it's better to abort. It's not
going to be able to do anything ... so don't finish
probing, and don't register this "dead" transceiver.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
jouni.hogander@nokia.com, broonie@sirena.org.uk
Subject: Re: [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver
Date: Tue, 10 Feb 2009 23:23:30 -0800 [thread overview]
Message-ID: <200902102323.30395.david-b@pacbell.net> (raw)
In-Reply-To: <1234336002-26372-1-git-send-email-kalle.jokiniemi@digia.com>
On Tuesday 10 February 2009, Kalle Jokiniemi wrote:
> These couple of patches enable dynamic swithcing of the
> regulators used by twl4030 usb tranceiver.
>
> This set replaces the single patch "USB: disable twl4030
> USB regulators when cable unplugged" sent previously.
> The change to previous version is that possible errors
> in regulator_get are now handled and the twl4030 usb
> driver requires TWL_REGULATOR support to be compiled.
It'd make more sense to me as a single patch ... :)
And also, instead of *continuing* after the regulators
can't be acquired, it's better to abort. It's not
going to be able to do anything ... so don't finish
probing, and don't register this "dead" transceiver.
- Dave
next prev parent reply other threads:[~2009-02-11 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 7:06 [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver Kalle Jokiniemi
[not found] ` <1234336002-26372-1-git-send-email-kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>
2009-02-11 7:06 ` [PATCH 1/2] TWL: USB: disable VUSB regulators when cable unplugged Kalle Jokiniemi
2009-02-11 7:06 ` Kalle Jokiniemi
2009-02-11 7:06 ` [PATCH 2/2] USB: OTG: Twl4030 depends on REGULATOR_TWL4030 Kalle Jokiniemi
2009-02-11 7:23 ` David Brownell [this message]
2009-02-11 7:23 ` [PATCH 0/2] TWL: USB: Start using twl4030/5030 regulator driver David Brownell
[not found] ` <200902102323.30395.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-11 10:47 ` Kalle Jokiniemi
2009-02-11 10:47 ` Kalle Jokiniemi
2009-02-13 9:57 ` Kalle Jokiniemi
2009-02-13 22:35 ` David Brownell
2009-02-20 8:56 ` Kalle Jokiniemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902102323.30395.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org \
--cc=jouni.hogander-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.