All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dean Nelson <dcn@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Tony Luck <tony.luck@intel.com>,
	linux-ia64 <linux-ia64@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree
Date: Wed, 11 Feb 2009 15:12:43 +0000	[thread overview]
Message-ID: <20090211151243.GC15814@sgi.com> (raw)
In-Reply-To: <20090211150536.GE10525@elte.hu>

On Wed, Feb 11, 2009 at 04:05:36PM +0100, Ingo Molnar wrote:
> 
> * Dean Nelson <dcn@sgi.com> wrote:
> 
> > On Tue, Feb 10, 2009 at 01:25:55PM -0800, Andrew Morton wrote:
> > > On Mon, 9 Feb 2009 10:25:20 -0600
> > > Dean Nelson <dcn@sgi.com> wrote:
> > > 
> > > > Fix the ia64 build error that occurs in the linux-next tree by introducing
> > > > an ia64 version of uv.h.  Additionally, clean up the usage of is_uv_system().
> > > 
> > > Would I be correct in believing that this repairs (and should be folded
> > > into)
> > > 
> > >   commit 5b221278d61e3907a5e4104a844b63bc8bb3d43a
> > >   Author: Ingo Molnar <mingo@elte.hu>
> > >   Date:   Wed Jan 21 11:30:07 2009 +0100
> > > 
> > >       x86: uv cleanup, build fix #2
> > > 
> > > ?
> > >
> > > (it looks like 5b221278d61e3907a5e4104a844b63bc8bb3d43a should be
> > > folded into something else, too.  What hath we wrought?)
> > 
> > Yes, it does fix an issue introduced by:
> > 
> >    commit: bdbcdd48883940bbd8d17eb01172d58a261a413a
> >    author: Tejun Heo <tj@kernel.org>
> >    date:   Wed, 21 Jan 2009 08:26:06 +0000
> > 
> > 	x86: uv cleanup
> > 
> > which the commit you mention above attempted to fix.
> > 
> > I'll leave it to you and Ingo to determine whether my patch should be
> > folded into Ingo's or Tejun's patch.
> > 
> > Ingo, I see that you've applied my patch to your tip tree. What are
> > your thoughts on Andrew's question?
> 
> What question was that? Folding back across that distance is not possible
> in a Git workflow. I do regular cross-builds - the build bug did not trigger
> with the ia64 defconfig.

The question was the one of folding the patch back. And by your response, I
see we'll be leaving things as they are.

Thanks,
Dean


WARNING: multiple messages have this Message-ID (diff)
From: Dean Nelson <dcn@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Tony Luck <tony.luck@intel.com>,
	linux-ia64 <linux-ia64@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree
Date: Wed, 11 Feb 2009 09:12:43 -0600	[thread overview]
Message-ID: <20090211151243.GC15814@sgi.com> (raw)
In-Reply-To: <20090211150536.GE10525@elte.hu>

On Wed, Feb 11, 2009 at 04:05:36PM +0100, Ingo Molnar wrote:
> 
> * Dean Nelson <dcn@sgi.com> wrote:
> 
> > On Tue, Feb 10, 2009 at 01:25:55PM -0800, Andrew Morton wrote:
> > > On Mon, 9 Feb 2009 10:25:20 -0600
> > > Dean Nelson <dcn@sgi.com> wrote:
> > > 
> > > > Fix the ia64 build error that occurs in the linux-next tree by introducing
> > > > an ia64 version of uv.h.  Additionally, clean up the usage of is_uv_system().
> > > 
> > > Would I be correct in believing that this repairs (and should be folded
> > > into)
> > > 
> > >   commit 5b221278d61e3907a5e4104a844b63bc8bb3d43a
> > >   Author: Ingo Molnar <mingo@elte.hu>
> > >   Date:   Wed Jan 21 11:30:07 2009 +0100
> > > 
> > >       x86: uv cleanup, build fix #2
> > > 
> > > ?
> > >
> > > (it looks like 5b221278d61e3907a5e4104a844b63bc8bb3d43a should be
> > > folded into something else, too.  What hath we wrought?)
> > 
> > Yes, it does fix an issue introduced by:
> > 
> >    commit: bdbcdd48883940bbd8d17eb01172d58a261a413a
> >    author: Tejun Heo <tj@kernel.org>
> >    date:   Wed, 21 Jan 2009 08:26:06 +0000
> > 
> > 	x86: uv cleanup
> > 
> > which the commit you mention above attempted to fix.
> > 
> > I'll leave it to you and Ingo to determine whether my patch should be
> > folded into Ingo's or Tejun's patch.
> > 
> > Ingo, I see that you've applied my patch to your tip tree. What are
> > your thoughts on Andrew's question?
> 
> What question was that? Folding back across that distance is not possible
> in a Git workflow. I do regular cross-builds - the build bug did not trigger
> with the ia64 defconfig.

The question was the one of folding the patch back. And by your response, I
see we'll be leaving things as they are.

Thanks,
Dean

  reply	other threads:[~2009-02-11 15:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-09 16:25 [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree Dean Nelson
2009-02-09 16:25 ` Dean Nelson
2009-02-10 21:25 ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next Andrew Morton
2009-02-10 21:25   ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree Andrew Morton
2009-02-11 15:01   ` Dean Nelson
2009-02-11 15:01     ` Dean Nelson
2009-02-11 15:05     ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next Ingo Molnar
2009-02-11 15:05       ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree Ingo Molnar
2009-02-11 15:12       ` Dean Nelson [this message]
2009-02-11 15:12         ` Dean Nelson
2009-02-11 18:58       ` Luck, Tony
2009-02-11 18:58         ` Luck, Tony
2009-02-11 19:33         ` Dean Nelson
2009-02-11 19:33           ` Dean Nelson
2009-02-11 20:25         ` Ingo Molnar
2009-02-11 20:25           ` Ingo Molnar
2009-02-11 12:32 ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next Ingo Molnar
2009-02-11 12:32   ` [PATCH] SGI IA64 UV: fix ia64 build error in the linux-next tree Ingo Molnar
2009-02-11 18:49   ` Luck, Tony
2009-02-11 18:49     ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090211151243.GC15814@sgi.com \
    --to=dcn@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.