From: Ingo Molnar <mingo@elte.hu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: x86 maintainers <x86@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64} builds
Date: Thu, 12 Feb 2009 08:26:44 +0100 [thread overview]
Message-ID: <20090212072644.GA10253@elte.hu> (raw)
In-Reply-To: <20090211172258.GE13239@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
>
> * David Woodhouse <dwmw2@infradead.org> wrote:
>
> > It is a steaming great pain in the arse when the value of CONFIG_64BIT
> > explicitly written in my .config file is overridden by the value of
> > $ARCH inferred from the environment.
> >
> > If I have a 32-bit .config and I happen to build it without remembering
> > to put 'ARCH=i386' on the make command line, it shouldn't force
> > CONFIG_64BIT=y and reconfigure.
> >
> > This patch should fix that, while still allowing defconfig to work as it
> > currently does for both 32-bit and 64-bit environments, and still giving
> > the default value of CONFIG_64BIT according to $ARCH. It's just that it
> > won't _force_ a change to CONFIG_64BIT when it's set to something other
> > than what $ARCH would imply.
> >
> > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>
> Applied to tip:x86/ugent, thanks David!
i removed it again, because it regresses randconfig behavior:
titan:~/tip> grep X86_32 .config; make ARCH=x86_64 randconfig; grep X86_32 .config
# CONFIG_X86_32 is not set
scripts/kconfig/conf -r arch/x86/Kconfig
#
# configuration written to .config
#
CONFIG_X86_32=y
CONFIG_X86_32_SMP=y
CONFIG_X86_32_LAZY_GS=y
CONFIG_X86_32_ALWAYS_ON=y
I dont mind the change you are after, but randconfig should work as
expected too: if ARCH=x86_64 is passed it should generate a 64-bit
randconfig, not a 50% 32-bit one.
Ingo
next prev parent reply other threads:[~2009-02-12 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 17:11 [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64} builds David Woodhouse
2009-02-11 17:22 ` Ingo Molnar
2009-02-12 7:26 ` Ingo Molnar [this message]
2009-02-12 8:36 ` David Woodhouse
2009-02-12 20:09 ` H. Peter Anvin
2009-02-13 11:12 ` Ingo Molnar
2009-06-30 11:10 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212072644.GA10253@elte.hu \
--to=mingo@elte.hu \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.