All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	x86 maintainers <x86@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64} builds
Date: Fri, 13 Feb 2009 12:12:22 +0100	[thread overview]
Message-ID: <20090213111222.GA15679@elte.hu> (raw)
In-Reply-To: <499481F2.3040107@zytor.com>


* H. Peter Anvin <hpa@zytor.com> wrote:

> David Woodhouse wrote:
>>
>> Ew, that's a nasty thing to be prioritising over day-to-day usability,
>> and the fact that I can't just do 'make bzImage' without it screwing up
>> and asking me to reconfigure.

That argument is flawed because it could be used against just about any
regression that happens in the kernel: if only the new behavior is
deemed more important than the regression that it introduces.

As i said, there's no real problem here, i dont mind the change you are
proposing, but it needs to be done without introducing clearly
nonsensical regressions.

>> Isn't there a CONFIG_RANDCONFIG option? We could make it
>>    bool "64-bit kernel" if !CONFIG_RANDCONFIG
>>
>> Alternatively, we could just the top-level Makefile set ARCH=x86 when
>> it's inferred from the environment, and let people override it to i386
>> or x86_64 if they want to.
>>
>
> I think the fundamental problem here is that "make randconfig" is  
> allowed to retain *any* information from the previous .config; the same  
> is true for "make all*config", "make defconfig", etc.  These by  
> definition should blast the current configuration away.
>
> Now, "make randconfig" should ideally be able to generate either a 32-  
> or a 64-bit configuration (which would have to be done correctly), but  
> if ARCH is set we need to honor it.

Yep, as long as an explicit ARCH override is honored i dont mind some
side-effects on randconfig. (although people do have scripting around
randconfig so we need to make sure it's all sane.)

	Ingo

  reply	other threads:[~2009-02-13 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 17:11 [PATCH] Don't override CONFIG_64BIT for ARCH={i386,x86_64} builds David Woodhouse
2009-02-11 17:22 ` Ingo Molnar
2009-02-12  7:26   ` Ingo Molnar
2009-02-12  8:36     ` David Woodhouse
2009-02-12 20:09       ` H. Peter Anvin
2009-02-13 11:12         ` Ingo Molnar [this message]
2009-06-30 11:10     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213111222.GA15679@elte.hu \
    --to=mingo@elte.hu \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.