All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: jbarnes@virtuousgeek.org
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Trent Piepho <xyzzy@speakeasy.org>, Alex Chiang <achiang@hp.com>
Subject: [RFC PATCH v2 01/12] PCI: don't scan existing devices
Date: Fri, 13 Feb 2009 13:18:58 -0700	[thread overview]
Message-ID: <20090213201858.19262.67639.stgit@bob.kio> (raw)
In-Reply-To: <20090213201135.19262.67924.stgit@bob.kio>

From: Trent Piepho <xyzzy@speakeasy.org>

pci_scan_single_device is supposed to add newly discovered
devices to pci_bus->devices, but doesn't check to see if the
device has already been added. This can cause problems if we ever
want to use this interface to rescan the PCI bus.

If the device is already added, just return it.

Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/pci/probe.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 55ec44a..66b5d1c 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1006,6 +1006,12 @@ struct pci_dev *__ref pci_scan_single_device(struct pci_bus *bus, int devfn)
 {
 	struct pci_dev *dev;
 
+	dev = pci_get_slot(bus, devfn);
+	if (dev) {
+		pci_dev_put(dev);
+		return dev;
+	}
+
 	dev = pci_scan_device(bus, devfn);
 	if (!dev)
 		return NULL;


  reply	other threads:[~2009-02-13 20:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 20:18 [RFC PATCH v2 00/12] PCI core learns hotplug Alex Chiang
2009-02-13 20:18 ` Alex Chiang [this message]
2009-02-13 20:19 ` [RFC PATCH v2 02/12] PCI: pci_scan_slot() returns newly found devices Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 03/12] PCI: always scan child buses Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 04/12] PCI: properly clean up ASPM link state on device remove Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 05/12] PCI: beef up pci_do_scan_bus() Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 06/12] PCI: Introduce /sys/bus/pci/rescan Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 07/12] PCI: Introduce /sys/bus/pci/devices/.../remove Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 08/12] PCI: Introduce /sys/bus/pci/devices/.../rescan Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 09/12] PCI Hotplug: restore fakephp interface with complete reimplementation Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 10/12] PCI Hotplug: rename legacy_fakephp to fakephp Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 11/12] PCI Hotplug: schedule fakephp for feature removal Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 12/12] PCI: more whitespace cleanups Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213201858.19262.67639.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.