All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: jbarnes@virtuousgeek.org
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alex Chiang <achiang@hp.com>
Subject: [RFC PATCH v2 05/12] PCI: beef up pci_do_scan_bus()
Date: Fri, 13 Feb 2009 13:19:18 -0700	[thread overview]
Message-ID: <20090213201918.19262.31746.stgit@bob.kio> (raw)
In-Reply-To: <20090213201135.19262.67924.stgit@bob.kio>

We have a nice interface for re-scanning a PCI bus which will
discover newly added devices, add them to the device tree, and
enable them properly.

Ensure that the bridge resources are properly sized and assigned
during the rescan.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/pci/hotplug-pci.c |   16 ++++++++++++----
 1 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/hotplug-pci.c b/drivers/pci/hotplug-pci.c
index 4d4a644..33ab2d2 100644
--- a/drivers/pci/hotplug-pci.c
+++ b/drivers/pci/hotplug-pci.c
@@ -6,13 +6,21 @@
 
 unsigned int __devinit pci_do_scan_bus(struct pci_bus *bus)
 {
-	unsigned int max;
+	unsigned int max, pass;
+	struct pci_dev *dev;
 
 	max = pci_scan_child_bus(bus);
 
-	/*
-	 * Make the discovered devices available.
-	 */
+	for (pass=0; pass < 2; pass++)
+		list_for_each_entry(dev, &bus->devices, bus_list) {
+			if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
+			    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
+				if (pass && dev->subordinate)
+					pci_bus_size_bridges(dev->subordinate);
+		}
+
+	pci_bus_assign_resources(bus);
+	pci_enable_bridges(bus);
 	pci_bus_add_devices(bus);
 
 	return max;


  parent reply	other threads:[~2009-02-13 20:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 20:18 [RFC PATCH v2 00/12] PCI core learns hotplug Alex Chiang
2009-02-13 20:18 ` [RFC PATCH v2 01/12] PCI: don't scan existing devices Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 02/12] PCI: pci_scan_slot() returns newly found devices Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 03/12] PCI: always scan child buses Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 04/12] PCI: properly clean up ASPM link state on device remove Alex Chiang
2009-02-13 20:19 ` Alex Chiang [this message]
2009-02-13 20:19 ` [RFC PATCH v2 06/12] PCI: Introduce /sys/bus/pci/rescan Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 07/12] PCI: Introduce /sys/bus/pci/devices/.../remove Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 08/12] PCI: Introduce /sys/bus/pci/devices/.../rescan Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 09/12] PCI Hotplug: restore fakephp interface with complete reimplementation Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 10/12] PCI Hotplug: rename legacy_fakephp to fakephp Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 11/12] PCI Hotplug: schedule fakephp for feature removal Alex Chiang
2009-02-13 20:19 ` [RFC PATCH v2 12/12] PCI: more whitespace cleanups Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213201918.19262.31746.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.