All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	sct@redhat.com, akpm@linux-foundation.org, adilger@sun.com
Subject: Re: [RESEND/PATCH] ext[234]: Return -EIO not -ESTALE on directory traversal missing inode
Date: Sun, 15 Feb 2009 00:39:12 -0500	[thread overview]
Message-ID: <20090215053912.GD10706@mini-me.lan> (raw)
In-Reply-To: <3e8340490902142053x18ae3c20q7018e0d8bc42636d@mail.gmail.com>

On Sat, Feb 14, 2009 at 11:53:48PM -0500, Bryan Donlan wrote:
> > I'm dubious about unlikely() here; OTOH, penalizing the error case
> > seems reasonable.
> 
> I can leave it without the unlikely(), as it was before, but as far as
> I can tell, this should never happen under a non-corrupted, non-broken
> hardware filesystem, so it seems like a reasonable annotation to me.

You're right.  I was looking at the wrong place in the source, and
thought this could happen if the lookup failed; but yes, you're right,
this case can only happen if the filesystem is corrupted or there is
an I/O error.

						- Ted

  reply	other threads:[~2009-02-15  5:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1234588099-8445-1-git-send-email-bdonlan@fushizen.net>
2009-02-14  5:18 ` [RESEND/PATCH] ext[234]: Return -EIO not -ESTALE on directory traversal missing inode Bryan Donlan
2009-02-14 14:14   ` Theodore Tso
2009-02-15  4:53     ` Bryan Donlan
2009-02-15  4:53       ` Bryan Donlan
2009-02-15  5:39       ` Theodore Tso [this message]
2009-02-17  1:10     ` [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory traversal through deleted inode Bryan Donlan
2009-02-20 17:53       ` Bryan Donlan
2009-02-20 17:53         ` Bryan Donlan
2009-02-20 17:59         ` Theodore Tso
2009-02-21  7:35           ` Bryan Donlan
2009-02-21  7:35             ` Bryan Donlan
2009-02-20 18:25         ` Andrew Morton
2009-02-20 18:25           ` Andrew Morton
     [not found] <1234588099-8445-1-git-sen--dry-run>
2009-02-14  5:17 ` [RESEND/PATCH] ext[234]: Return -EIO not -ESTALE on directory traversal missing inode d-email-bdonlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090215053912.GD10706@mini-me.lan \
    --to=tytso@mit.edu \
    --cc=adilger@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=bdonlan@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.