From: Andrew Morton <akpm@linux-foundation.org>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sct@redhat.com, adilger@sun.com, tytso@mit.edu
Subject: Re: [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory traversal through deleted inode
Date: Fri, 20 Feb 2009 10:25:08 -0800 [thread overview]
Message-ID: <20090220102508.fc4e1feb.akpm@linux-foundation.org> (raw)
In-Reply-To: <3e8340490902200953p704fd9dbuff0a7a890895ea23@mail.gmail.com>
On Fri, 20 Feb 2009 12:53:39 -0500 Bryan Donlan <bdonlan@gmail.com> wrote:
> On Mon, Feb 16, 2009 at 8:10 PM, Bryan Donlan <bdonlan@gmail.com> wrote:
>
> > + if (unlikely(IS_ERR(inode))) {
> > + if (PTR_ERR(inode) == -ESTALE) {
> > + ext3_error(dir->i_sb, "ext2_lookup",
> > + "deleted inode referenced: %lu",
> > + ino);
> > + return ERR_PTR(-EIO);
> > + } else {
> > + return ERR_CAST(inode);
> > + }
> > + }
>
> I just noticed that I forgot to edit the function name in the
> ext3_error and ext4_error invocations... Would it be better to send a
> delta to fix this or resubmit the whole thing?
I just edited the diffs on my copies - switched all three to __func__.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
sct@redhat.com, adilger@sun.com, tytso@mit.edu
Subject: Re: [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory traversal through deleted inode
Date: Fri, 20 Feb 2009 10:25:08 -0800 [thread overview]
Message-ID: <20090220102508.fc4e1feb.akpm@linux-foundation.org> (raw)
In-Reply-To: <3e8340490902200953p704fd9dbuff0a7a890895ea23@mail.gmail.com>
On Fri, 20 Feb 2009 12:53:39 -0500 Bryan Donlan <bdonlan@gmail.com> wrote:
> On Mon, Feb 16, 2009 at 8:10 PM, Bryan Donlan <bdonlan@gmail.com> wrote:
>
> > + if (unlikely(IS_ERR(inode))) {
> > + if (PTR_ERR(inode) == -ESTALE) {
> > + ext3_error(dir->i_sb, "ext2_lookup",
> > + "deleted inode referenced: %lu",
> > + ino);
> > + return ERR_PTR(-EIO);
> > + } else {
> > + return ERR_CAST(inode);
> > + }
> > + }
>
> I just noticed that I forgot to edit the function name in the
> ext3_error and ext4_error invocations... Would it be better to send a
> delta to fix this or resubmit the whole thing?
I just edited the diffs on my copies - switched all three to __func__.
next prev parent reply other threads:[~2009-02-20 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1234588099-8445-1-git-send-email-bdonlan@fushizen.net>
2009-02-14 5:18 ` [RESEND/PATCH] ext[234]: Return -EIO not -ESTALE on directory traversal missing inode Bryan Donlan
2009-02-14 14:14 ` Theodore Tso
2009-02-15 4:53 ` Bryan Donlan
2009-02-15 4:53 ` Bryan Donlan
2009-02-15 5:39 ` Theodore Tso
2009-02-17 1:10 ` [PATCH v2] ext[234]: Return -EIO not -ESTALE on directory traversal through deleted inode Bryan Donlan
2009-02-20 17:53 ` Bryan Donlan
2009-02-20 17:53 ` Bryan Donlan
2009-02-20 17:59 ` Theodore Tso
2009-02-21 7:35 ` Bryan Donlan
2009-02-21 7:35 ` Bryan Donlan
2009-02-20 18:25 ` Andrew Morton [this message]
2009-02-20 18:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220102508.fc4e1feb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger@sun.com \
--cc=bdonlan@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.