From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: 1/7: Extend 'info vnc' output to show client
Date: Sun, 15 Feb 2009 11:43:12 +0000 [thread overview]
Message-ID: <20090215114312.GF4795@redhat.com> (raw)
In-Reply-To: <4995BC63.8040501@us.ibm.com>
On Fri, Feb 13, 2009 at 12:30:59PM -0600, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >The current 'info vnc' monitor output just displays the VNC server address
> >as provided by the -vnc command line flag. This isn't particularly useful
> >since it doesn't tell you what VNC is actually listening on. eg, if you
> >use '-vnc :1' it is useful to know whether this translated to
> >'0.0.0.0:5901'
> >or chose IPv6 ':::5901'. It is also useful to know the address of the
> >client that is currently connected. It is also useful to know the active
> >authentication (if any).
> >
> >@@ -2518,3 +2626,11 @@ int vnc_display_open(DisplayState *ds, c
> >
> > return qemu_set_fd_handler2(vs->lsock, vnc_listen_poll,
> > vnc_listen_read, NULL, vs);
> > }
> >+
> >+/*
> >+ * Local variables:
> >+ * c-indent-level: 4
> >+ * c-basic-offset: 4
> >+ * tab-width: 8
> >+ * End:
> >+ */
> >
>
> I'd prefer you not add this randomly in a patch.
Sorry, I added this to all the files I touched as QEMU's indentation rules
don't match the default emacs & emacs will thus mess up all the whitespace.
That said vnc.c already has alot of inconsistent whitespace :-( I'll strip
this chunk out of future patches before submission.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
next prev parent reply other threads:[~2009-02-15 11:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 14:53 [Qemu-devel] PATCH: 0/7: Support SASL authentication in VNC server Daniel P. Berrange
2009-02-12 15:01 ` [Qemu-devel] PATCH: 1/7: Extend 'info vnc' output to show client Daniel P. Berrange
2009-02-13 18:30 ` Anthony Liguori
2009-02-15 11:43 ` Daniel P. Berrange [this message]
2009-02-15 18:22 ` Anthony Liguori
2009-02-18 21:10 ` [Qemu-devel] " Mike Day
2009-02-12 15:02 ` [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h Daniel P. Berrange
2009-02-14 22:09 ` Anthony Liguori
2009-02-15 11:43 ` Daniel P. Berrange
2009-02-12 15:02 ` [Qemu-devel] PATCH: 3/7: Split out VNC TLS auth code to separate file Daniel P. Berrange
2009-02-12 15:03 ` [Qemu-devel] PATCH: 4/7: Add SASL authentication extension to VNC Daniel P. Berrange
2009-02-12 15:03 ` [Qemu-devel] PATCH: 5/7: Include auth credentials in 'info vnc' Daniel P. Berrange
2009-02-12 15:04 ` [Qemu-devel] PATCH: 6/7: Support simple ACL for client authorization Daniel P. Berrange
2009-02-14 22:14 ` Anthony Liguori
2009-02-12 15:04 ` [Qemu-devel] PATCH: 7/7: Add external persistent ACL file Daniel P. Berrange
2009-02-14 22:16 ` Anthony Liguori
2009-02-15 11:28 ` Daniel P. Berrange
2009-02-12 15:43 ` [Qemu-devel] PATCH: 0/7: Support SASL authentication in VNC server Daniel P. Berrange
2009-02-14 22:17 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215114312.GF4795@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.