Re: [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h

["Daniel P. Berrange" <berrange@redhat.com>]

On Sat, Feb 14, 2009 at 04:09:31PM -0600, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >This patch moves the declaration for the VncState struct out of the
> >vnc.c file and into vnc.h. This is to prepare for next patches which
> >have the auth mechanisms implementated in separate vnc-auth-vencrypt.c
> >and vnc-auth-sasl.c files
> >
> >In doing this, I discovered that there is a pile of duplicated keymap
> >code statically compiled into all the console frontends. A couple of
> >trivial changes allowed this to be sanitized, so instead of doing
> >a #include "keymaps.c", duplicating all code, we can have a shared
> >keymaps.h file, and only compile code once.
> >  
> 
> It would be better if you split the keymap cleanup into a different patch.

Ok, easy enough todo. I'll post new patch to deal with this keymap change
first.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|