All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Christoph Lameter <cl@linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-crypto@vger.kernel.org, Geert.Uytterhoeven@sonycom.com
Subject: Re: [PATCH] Export symbol ksize()
Date: Sun, 15 Feb 2009 13:36:38 -0800	[thread overview]
Message-ID: <20090215133638.5ef517ac.akpm@linux-foundation.org> (raw)
In-Reply-To: <1234454104.28812.175.camel@penberg-laptop>

On Thu, 12 Feb 2009 17:55:04 +0200 Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Thu, Feb 12, 2009 at 12:45:21PM +0200, Pekka Enberg wrote:
> > > 
> > > Because the API was being widely abused in the nommu code, for example.
> > > I'd rather not add it back for this special case which can be handled
> > > otherwise.
> 
> On Thu, 2009-02-12 at 18:50 +0800, Herbert Xu wrote:
> > I'm sorry but that's like banning the use of heaters just because
> > they can abused and cause fires.
> > 
> > I think I've said this to you before but in networking we very much
> > want to use ksize because the standard case of a 1500-byte packet
> > has loads of extra room given by kmalloc which all goes to waste
> > right now.
> > 
> > If we could use ksize then we can stuff loads of metadata in that
> > space.
> 
> OK, fair enough, I applied Kirill's patch. Thanks.
> 

Could we please have more details regarding this:

> The ksize() function is not exported to modules because it has non-standard
> behavour across different slab allocators. 

How does the behaviour differ?  It this documented?  Can we fix it?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Christoph Lameter <cl@linux-foundation.org>,
	Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-crypto@vger.kernel.org, Geert.Uytterhoeven@sonycom.com
Subject: Re: [PATCH] Export symbol ksize()
Date: Sun, 15 Feb 2009 13:36:38 -0800	[thread overview]
Message-ID: <20090215133638.5ef517ac.akpm@linux-foundation.org> (raw)
In-Reply-To: <1234454104.28812.175.camel@penberg-laptop>

On Thu, 12 Feb 2009 17:55:04 +0200 Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Thu, Feb 12, 2009 at 12:45:21PM +0200, Pekka Enberg wrote:
> > > 
> > > Because the API was being widely abused in the nommu code, for example.
> > > I'd rather not add it back for this special case which can be handled
> > > otherwise.
> 
> On Thu, 2009-02-12 at 18:50 +0800, Herbert Xu wrote:
> > I'm sorry but that's like banning the use of heaters just because
> > they can abused and cause fires.
> > 
> > I think I've said this to you before but in networking we very much
> > want to use ksize because the standard case of a 1500-byte packet
> > has loads of extra room given by kmalloc which all goes to waste
> > right now.
> > 
> > If we could use ksize then we can stuff loads of metadata in that
> > space.
> 
> OK, fair enough, I applied Kirill's patch. Thanks.
> 

Could we please have more details regarding this:

> The ksize() function is not exported to modules because it has non-standard
> behavour across different slab allocators. 

How does the behaviour differ?  It this documented?  Can we fix it?

  parent reply	other threads:[~2009-02-15 21:36 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10 13:21 [PATCH] Export symbol ksize() Kirill A. Shutemov
2009-02-10 13:21 ` Kirill A. Shutemov
2009-02-10 13:35 ` Pekka Enberg
2009-02-10 13:35   ` Pekka Enberg
2009-02-10 13:46   ` Kirill A. Shutemov
2009-02-10 14:06     ` Pekka J Enberg
2009-02-10 14:06       ` Pekka J Enberg
2009-02-10 14:06       ` Pekka J Enberg
2009-02-12 10:43       ` Herbert Xu
2009-02-12 10:43         ` Herbert Xu
2009-02-12 10:45         ` Pekka Enberg
2009-02-12 10:45           ` Pekka Enberg
2009-02-12 10:50           ` Herbert Xu
2009-02-12 10:50             ` Herbert Xu
2009-02-12 13:10             ` Nick Piggin
2009-02-12 13:10               ` Nick Piggin
2009-02-12 23:09               ` Herbert Xu
2009-02-12 23:09                 ` Herbert Xu
2009-02-12 23:37                 ` Matt Mackall
2009-02-12 23:37                   ` Matt Mackall
2009-02-13 13:20                   ` Nick Piggin
2009-02-13 13:20                     ` Nick Piggin
2009-02-13 16:57                     ` Kyle Moffett
2009-02-13 16:57                       ` Kyle Moffett
2009-02-12 15:55             ` Pekka Enberg
2009-02-12 15:55               ` Pekka Enberg
2009-02-12 23:09               ` Herbert Xu
2009-02-12 23:09                 ` Herbert Xu
2009-02-15 21:36               ` Andrew Morton [this message]
2009-02-15 21:36                 ` Andrew Morton
2009-02-15 21:43                 ` Matt Mackall
2009-02-15 21:43                   ` Matt Mackall
2009-02-15 21:55                   ` Andrew Morton
2009-02-15 21:55                     ` Andrew Morton
2009-02-15 23:49                     ` Matt Mackall
2009-02-15 23:49                       ` Matt Mackall
2009-02-16  1:00                       ` Andrew Morton
2009-02-16  1:00                         ` Andrew Morton
2009-02-16  1:21                         ` Herbert Xu
2009-02-16  1:21                           ` Herbert Xu
2009-02-16  1:28                           ` Matt Mackall
2009-02-16  1:28                             ` Matt Mackall
2009-02-16  1:52                             ` Herbert Xu
2009-02-16  1:52                               ` Herbert Xu
2009-02-16  1:54                               ` Matt Mackall
2009-02-16  1:54                                 ` Matt Mackall
2009-02-16  1:57                                 ` Herbert Xu
2009-02-16  1:57                                   ` Herbert Xu
2009-02-16  1:38                         ` Matt Mackall
2009-02-16  1:38                           ` Matt Mackall
2009-02-17  8:43                           ` Geert Uytterhoeven
2009-02-17  8:43                             ` Geert Uytterhoeven
2009-02-17  8:43                             ` Geert Uytterhoeven
2009-02-17 16:17                       ` Christoph Lameter
2009-02-17 16:17                         ` Christoph Lameter
2009-02-17 17:03                         ` Pekka Enberg
2009-02-17 17:03                           ` Pekka Enberg
2009-02-17 17:06                           ` Christoph Lameter
2009-02-17 17:06                             ` Christoph Lameter
2009-02-16 13:56       ` Johannes Weiner
2009-02-16 13:56         ` Johannes Weiner
2009-02-16 14:09         ` Pekka Enberg
2009-02-16 14:09           ` Pekka Enberg
2009-02-16 16:32         ` Joe Perches
2009-02-16 16:32           ` Joe Perches
2009-02-16 17:29           ` Pekka Enberg
2009-02-16 17:29             ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090215133638.5ef517ac.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=cl@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kirill@shutemov.name \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.