From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/8] kzfree()
Date: Mon, 16 Feb 2009 11:59:31 -0800 [thread overview]
Message-ID: <20090216115931.12d9b7ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090216142926.440561506@cmpxchg.org>
On Mon, 16 Feb 2009 15:29:26 +0100 Johannes Weiner <hannes@cmpxchg.org> wrote:
> This series introduces kzfree() and converts callsites which do
> memset() + kfree() explicitely.
I dunno, this looks like putting lipstick on a pig.
What is the point in zeroing memory just before freeing it? afacit
this is always done as a poor-man's poisoning operation.
But the slab allocators _already_ do poisoning, and they do it better.
And they do it configurably, whereas those sites you've been looking at
are permanently slowing the kernel down.
So I would cheerily merge and push patches titled "remove pointless
memset before kfree".
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/8] kzfree()
Date: Mon, 16 Feb 2009 11:59:31 -0800 [thread overview]
Message-ID: <20090216115931.12d9b7ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090216142926.440561506@cmpxchg.org>
On Mon, 16 Feb 2009 15:29:26 +0100 Johannes Weiner <hannes@cmpxchg.org> wrote:
> This series introduces kzfree() and converts callsites which do
> memset() + kfree() explicitely.
I dunno, this looks like putting lipstick on a pig.
What is the point in zeroing memory just before freeing it? afacit
this is always done as a poor-man's poisoning operation.
But the slab allocators _already_ do poisoning, and they do it better.
And they do it configurably, whereas those sites you've been looking at
are permanently slowing the kernel down.
So I would cheerily merge and push patches titled "remove pointless
memset before kfree".
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-16 19:59 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 14:29 [patch 0/8] kzfree() Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 14:29 ` [patch 1/8] slab: introduce kzfree() Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 15:27 ` Johannes Weiner
2009-02-16 15:27 ` Johannes Weiner
2009-02-17 15:08 ` Christoph Lameter
2009-02-17 15:08 ` Christoph Lameter
2009-02-17 15:51 ` Pekka Enberg
2009-02-17 15:51 ` Pekka Enberg
2009-02-17 16:01 ` Christoph Lameter
2009-02-17 16:01 ` Christoph Lameter
2009-02-16 14:29 ` [patch 2/8] crypto: use kzfree() Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 14:29 ` [patch 3/8] s390: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 14:29 ` [patch 4/8] md: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 14:29 ` [patch 5/8] usb: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 14:29 ` [patch 6/8] cifs: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 15:13 ` Pekka Enberg
2009-02-16 15:13 ` Pekka Enberg
2009-02-16 15:33 ` Johannes Weiner
2009-02-16 15:33 ` Johannes Weiner
2009-02-16 18:17 ` Pekka Enberg
2009-02-16 18:17 ` Pekka Enberg
2009-02-16 19:01 ` Steve French
2009-02-16 19:02 ` Steve French
2009-02-16 19:02 ` Steve French
2009-02-16 14:29 ` [patch 7/8] ecryptfs: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 20:02 ` Andrew Morton
2009-02-16 20:02 ` Andrew Morton
2009-02-16 20:28 ` Johannes Weiner
2009-02-16 20:28 ` Johannes Weiner
2009-02-17 7:51 ` Tyler Hicks
2009-02-16 14:29 ` [patch 8/8] atm: " Johannes Weiner
2009-02-16 14:29 ` Johannes Weiner
2009-02-16 19:59 ` Andrew Morton [this message]
2009-02-16 19:59 ` [patch 0/8] kzfree() Andrew Morton
2009-02-16 19:58 ` Pekka Enberg
2009-02-16 19:58 ` Pekka Enberg
2009-02-16 20:19 ` Andrew Morton
2009-02-16 20:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090216115931.12d9b7ed.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.