"elf core dump: fix get_user use" breaks mips compilation

"elf core dump: fix get_user use" breaks mips compilation

[Martin Michlmayr]

Hi Roland,

Your change "elf core dump: fix get_user use"  (which made it into
2.6.28.5) breaks the compilation on MIPS (which sets -Werror):

  CC      arch/mips/kernel/binfmt_elfn32.o
cc1: warnings being treated as errors
arch/mips/kernel/../../../fs/binfmt_elf.c: In function ‘vma_dump_size’:
arch/mips/kernel/../../../fs/binfmt_elf.c:1202: warning: ‘word’ may be used uninitialized in this function
make[1]: *** [arch/mips/kernel/binfmt_elfn32.o] Error 1

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: "elf core dump: fix get_user use" breaks mips compilation

[Roland McGrath]

That is either a compiler problem or a problem with how the asm magic used
inside get_user() informs the compiler.  The dynamics of the code are not
actually much different than before the change.  

I imagine this would work around it:

--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1211,7 +1211,7 @@ static unsigned long vma_dump_size(struc
 	if (FILTER(ELF_HEADERS) &&
 	    vma->vm_pgoff == 0 && (vma->vm_flags & VM_READ)) {
 		u32 __user *header = (u32 __user *) vma->vm_start;
-		u32 word;
+		u32 word = 0;
 		mm_segment_t fs = get_fs();
 		/*
 		 * Doing it this way gets the constant folded by GCC.

Re: "elf core dump: fix get_user use" breaks mips compilation

[Martin Michlmayr]

* Roland McGrath <roland@redhat.com> [2009-02-16 13:25]:
> I imagine this would work around it:
> 
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1211,7 +1211,7 @@ static unsigned long vma_dump_size(struc
>  	if (FILTER(ELF_HEADERS) &&
>  	    vma->vm_pgoff == 0 && (vma->vm_flags & VM_READ)) {
>  		u32 __user *header = (u32 __user *) vma->vm_start;
> -		u32 word;
> +		u32 word = 0;

Tested-by: Martin Michlmayr <tbm@cyrius.com>

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: "elf core dump: fix get_user use" breaks mips compilation

[Ralf Baechle]

On Mon, Feb 16, 2009 at 01:01:36PM +0100, Martin Michlmayr wrote:

> Hi Roland,
> 
> Your change "elf core dump: fix get_user use"  (which made it into
> 2.6.28.5) breaks the compilation on MIPS (which sets -Werror):
> 
>   CC      arch/mips/kernel/binfmt_elfn32.o
> cc1: warnings being treated as errors
> arch/mips/kernel/../../../fs/binfmt_elf.c: In function ‘vma_dump_size’:
> arch/mips/kernel/../../../fs/binfmt_elf.c:1202: warning: ‘word’ may be used uninitialized in this function
> make[1]: *** [arch/mips/kernel/binfmt_elfn32.o] Error 1

Partially expanding get_user() the code basically does this:

	int word;

	if (access_ok(...))
		__get_user(word, header);
	else
		word = 0;

And gcc is unable to figure out that word will always be assigned to by
both paths of the if statement.  Older gcc versions used to have that
problem.  I can't reproduce your problem with gcc 4.3.2 and I assume
you're using something older than that?

  Ralf

Re: "elf core dump: fix get_user use" breaks mips compilation

[Martin Michlmayr]

* Ralf Baechle <ralf@linux-mips.org> [2009-02-16 23:32]:
> Partially expanding get_user() the code basically does this:
> 
> 	int word;
> 
> 	if (access_ok(...))
> 		__get_user(word, header);
> 	else
> 		word = 0;
> 
> And gcc is unable to figure out that word will always be assigned to by
> both paths of the if statement.  Older gcc versions used to have that
> problem.  I can't reproduce your problem with gcc 4.3.2 and I assume
> you're using something older than that?

Yes, gcc 4.1.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: "elf core dump: fix get_user use" breaks mips compilation

[Christian Borntraeger]

Am Tuesday 17 February 2009 00:32:16 schrieb Ralf Baechle:
> On Mon, Feb 16, 2009 at 01:01:36PM +0100, Martin Michlmayr wrote:
> > Hi Roland,
> >
> > Your change "elf core dump: fix get_user use"  (which made it into
> > 2.6.28.5) breaks the compilation on MIPS (which sets -Werror):

Since several gcc versions are known to produce false warning, the proper
fix should be to remove -Werror, no?

Christian