All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mingo@elte.hu
Cc: sam@ravnborg.org, jeremy@goop.org, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org, gitster@pobox.com,
	caglar@pardus.org.tr
Subject: Re: [PATCH] Add *.rej to .gitignore
Date: Tue, 17 Feb 2009 17:05:02 -0800 (PST)	[thread overview]
Message-ID: <20090217.170502.86474205.davem@davemloft.net> (raw)
In-Reply-To: <20090218004919.GG25856@elte.hu>

From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 18 Feb 2009 01:49:19 +0100

> I'd argue with calling it 'naive', i'd call it 'dangerous'. 
> 
> Anyway, i definitely dont want to prevent others from having a 
> defense against mistakes (even if those mistakes are at least 
> partly self-inflicted).
> 
> My only beef is that i think i have a good workflow, still i 
> have no efficient automated defense against .rej files getting 
> into the tree. I have to use 'git commit -n' too frequently, and 
> that overrides the pre-commit hook.
> 
> I.e. i should start using the workflow i consider more dangerous 
> - and i should start removing .rej files while they are clearly 
> useful even after the commit.
> 
> Isnt that backwards?

I think by and large most people only commit with explicit additions
into the index file either by specifying files explicitly on the
"git commit" command line or explicitly calling "git add".

You see a problem when you're telling git "look at my tree and figure
out what to commit."  Putting the kitchen sink into .gitignore and
relying upon that is not a tenable solution.

Instead of hoping git does exactly what you want it to do, tell
it explicitly.

  reply	other threads:[~2009-02-18  1:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 19:59 [PATCH] Add *.rej to .gitignore Jeremy Fitzhardinge
2009-02-17 20:08 ` Sam Ravnborg
2009-02-17 21:16 ` Linus Torvalds
2009-02-17 21:36   ` Ingo Molnar
2009-02-17 22:20   ` Alexey Dobriyan
2009-02-17 22:38 ` David Miller
2009-02-18  0:05   ` Ingo Molnar
2009-02-18  0:40     ` Sam Ravnborg
2009-02-18  0:49       ` Ingo Molnar
2009-02-18  1:05         ` David Miller [this message]
2009-02-18 15:21         ` Stefan Richter
     [not found] <c6Eh1-7Og-19@gated-at.bofh.it>
     [not found] ` <c6GLO-3xO-35@gated-at.bofh.it>
     [not found]   ` <c6IaO-60k-5@gated-at.bofh.it>
2009-02-19 20:25     ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217.170502.86474205.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=caglar@pardus.org.tr \
    --cc=gitster@pobox.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.