From: Sam Ravnborg <sam@ravnborg.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ingo Molnar" <mingo@elte.hu>,
"\"S.Çağlar Onur\"" <caglar@pardus.org.tr>
Subject: Re: [PATCH] Add *.rej to .gitignore
Date: Tue, 17 Feb 2009 21:08:53 +0100 [thread overview]
Message-ID: <20090217200853.GA28693@uranus.ravnborg.org> (raw)
In-Reply-To: <499B1729.5040802@goop.org>
On Tue, Feb 17, 2009 at 11:59:37AM -0800, Jeremy Fitzhardinge wrote:
> *.rej files really are unwanted. If there are any .rej files, they can be
> found by
> some other means (perhaps git itself could warn when committing with *.rej
> files present,
> or add some distinct notion of "ignored files" vs "never commit" files).
>
> (This effectively reverts 1f5d3a6b6532e25a5cdf1f311956b2b03d343a48)
When working with patch having .rej files to show up in "git status"
and "git commit" is a nice reminder to you that there was
some manual work to be done.
So unless git are educated to remind you by other means we should
keep the current behaviour and be reminded when we see .rej
files present in "git status" / "git commit".
In other words - I do not agree on applying this patch.
Sam
next prev parent reply other threads:[~2009-02-17 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 19:59 [PATCH] Add *.rej to .gitignore Jeremy Fitzhardinge
2009-02-17 20:08 ` Sam Ravnborg [this message]
2009-02-17 21:16 ` Linus Torvalds
2009-02-17 21:36 ` Ingo Molnar
2009-02-17 22:20 ` Alexey Dobriyan
2009-02-17 22:38 ` David Miller
2009-02-18 0:05 ` Ingo Molnar
2009-02-18 0:40 ` Sam Ravnborg
2009-02-18 0:49 ` Ingo Molnar
2009-02-18 1:05 ` David Miller
2009-02-18 15:21 ` Stefan Richter
[not found] <c6Eh1-7Og-19@gated-at.bofh.it>
[not found] ` <c6GLO-3xO-35@gated-at.bofh.it>
[not found] ` <c6IaO-60k-5@gated-at.bofh.it>
2009-02-19 20:25 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217200853.GA28693@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=caglar@pardus.org.tr \
--cc=gitster@pobox.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.