From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Simplify skb_tx_hash()
Date: Tue, 17 Feb 2009 22:53:55 -0800 (PST) [thread overview]
Message-ID: <20090217.225355.184526778.davem@davemloft.net> (raw)
In-Reply-To: <20090218053211.16619.33544.sendpatchset@localhost.localdomain>
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Wed, 18 Feb 2009 11:02:11 +0530
> From: Krishna Kumar <krkumar2@in.ibm.com>
>
> The initialization of skb_tx_hashrnd is moved so that it gets called
> after "random" driver is initialized. Random numbers generated at this
> point are different across 3 immediate reboots:
> (reboot1) Random number: 0xd52f08b6
> (reboot2) Random number: 0x8beeef46
> (reboot3) Random number: 0x7d60a4b6
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Well, two questions:
1) How in the world are you getting a packet transmitted
before the random driver initializes?
2) How can an initcall be more random than when the first
packet is transmitted by the system?
A patch like this needs justification, so in your commit
logs you shouldn't just list out mechanically what your
patch is doing, but rather explain "why".
next prev parent reply other threads:[~2009-02-18 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 5:32 [PATCH] net: Simplify skb_tx_hash() Krishna Kumar
2009-02-18 6:53 ` David Miller [this message]
2009-02-18 7:27 ` Krishna Kumar2
2009-02-18 7:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217.225355.184526778.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.