From: David Miller <davem@davemloft.net>
To: krkumar2@in.ibm.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Simplify skb_tx_hash()
Date: Tue, 17 Feb 2009 23:41:58 -0800 (PST) [thread overview]
Message-ID: <20090217.234158.156650176.davem@davemloft.net> (raw)
In-Reply-To: <OF35128638.A15DA997-ON65257561.00265DD2-65257561.0028F5BC@in.ibm.com>
From: Krishna Kumar2 <krkumar2@in.ibm.com>
Date: Wed, 18 Feb 2009 12:57:23 +0530
> > David Miller <davem@davemloft.net>
> > A patch like this needs justification, so in your commit
> > logs you shouldn't just list out mechanically what your
> > patch is doing, but rather explain "why".
>
> Please let me know if I should give a better text for justification?
Even after reading all of this I still don't understand why
you're making the change.
Is it to eliminate the comparison every packet in skb_tx_hash()?
If so, say that in the commit message so nobody has to
guess. Saying just "simplify" doesn't express that at all.
prev parent reply other threads:[~2009-02-18 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 5:32 [PATCH] net: Simplify skb_tx_hash() Krishna Kumar
2009-02-18 6:53 ` David Miller
2009-02-18 7:27 ` Krishna Kumar2
2009-02-18 7:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217.234158.156650176.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.