[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Tao Ma]

In ctime updating of xattr, it use the wrong type of access for
inode, so use ocfs2_journal_access_di instead.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
---
 fs/ocfs2/xattr.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 915039f..e393315 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -2592,8 +2592,9 @@ static int __ocfs2_xattr_set_handle(struct inode *inode,
 
 	if (!ret) {
 		/* Update inode ctime. */
-		ret = ocfs2_journal_access(ctxt->handle, inode, xis->inode_bh,
-					   OCFS2_JOURNAL_ACCESS_WRITE);
+		ret = ocfs2_journal_access_di(ctxt->handle, inode,
+					      xis->inode_bh,
+					      OCFS2_JOURNAL_ACCESS_WRITE);
 		if (ret) {
 			mlog_errno(ret);
 			goto out;
-- 
1.5.5

[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Joel Becker]

On Tue, Feb 17, 2009 at 04:39:28AM +0800, Tao Ma wrote:
> In ctime updating of xattr, it use the wrong type of access for
> inode, so use ocfs2_journal_access_di instead.
> 
> Signed-off-by: Tao Ma <tao.ma@oracle.com>

	Eek!  How did tristan's and my testing miss this?  Mark, this is
a bugfix for .29.

Signed-off-by: Joel Becker <joel.becker@oracle.com>

-- 

"In the beginning, the universe was created. This has made a lot 
 of people very angry, and is generally considered to have been a 
 bad move."
        - Douglas Adams

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Tao Ma]

Joel Becker wrote:
> On Tue, Feb 17, 2009 at 04:39:28AM +0800, Tao Ma wrote:
>> In ctime updating of xattr, it use the wrong type of access for
>> inode, so use ocfs2_journal_access_di instead.
>>
>> Signed-off-by: Tao Ma <tao.ma@oracle.com>
> 
> 	Eek!  How did tristan's and my testing miss this?  Mark, this is
> a bugfix for .29.
actually tristan's test case found this and I just don't have time to 
investigate on it until now. 
http://oss.oracle.com/bugzilla/show_bug.cgi?id=1065

Thank you, tristan.

Regards,
Tao

[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Joel Becker]

On Tue, Feb 17, 2009 at 01:56:04PM +0800, Tao Ma wrote:
>> 	Eek!  How did tristan's and my testing miss this?  Mark, this is
>> a bugfix for .29.
> actually tristan's test case found this and I just don't have time to  
> investigate on it until now.  
> http://oss.oracle.com/bugzilla/show_bug.cgi?id=1065
>
> Thank you, tristan.

	Oh, awesome.  Thank you, tristan, indeed!  Perhaps the patch
needs a Reported-by: Tristan... tag.

Joel

-- 

"Anything that is too stupid to be spoken is sung."  
        - Voltaire

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] [PATCH] ocfs2: Use the right access_* method in ctime update of xattr.

[Sunil Mushran]

Joel Becker wrote:
> 	Oh, awesome.  Thank you, tristan, indeed!  Perhaps the patch
> needs a Reported-by: Tristan... tag

Yes. We should start adding Reported-by and Tested-by in fixes.