From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] x86: memtest: adapt log messages
Date: Tue, 17 Feb 2009 11:29:33 +0100 [thread overview]
Message-ID: <20090217102933.GD6298@alberich.amd.com> (raw)
In-Reply-To: <20090213165302.GA24299@elte.hu>
On Fri, Feb 13, 2009 at 05:53:02PM +0100, Ingo Molnar wrote:
>
> * Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
>
> > +#ifdef CONFIG_X86_64
> > + printk(KERN_CONT "\n %010llx - %010llx pattern %016llx",
> > + t_start, t_start + t_size, cpu_to_be64(pattern));
> > +#else
> > + printk(KERN_CONT "\n %010llx - %010llx pattern %08x",
> > + t_start, t_start + t_size, cpu_to_be32(pattern));
> > +#endif
>
> hm, is there really no cleaner way to do this?
There is -- but only if 32-bit-code is changed to use u64 for the test
pattern.
Andreas
next prev parent reply other threads:[~2009-02-17 10:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 14:46 [PATCH 0/7] x86: memtest update Andreas Herrmann
2009-02-13 14:49 ` [PATCH 1/7] x86: memtest: reuse test patterns when memtest parameter exceeds number of available patterns Andreas Herrmann
2009-02-13 14:51 ` [PATCH 2/7] x86: memtest: introduce array to store memtest patterns Andreas Herrmann
2009-02-13 17:52 ` H. Peter Anvin
2009-02-17 10:24 ` Andreas Herrmann
2009-02-17 20:58 ` Yinghai Lu
2009-02-13 14:52 ` [PATCH 3/7] x86: memtest: cleanup memtest function Andreas Herrmann
2009-02-13 14:55 ` [PATCH 4/7] x86: memtest: adapt log messages Andreas Herrmann
2009-02-13 16:53 ` Ingo Molnar
2009-02-13 17:04 ` Jaswinder Singh Rajput
2009-02-13 17:46 ` H. Peter Anvin
2009-02-17 10:27 ` Andreas Herrmann
2009-02-17 10:29 ` Andreas Herrmann [this message]
2009-02-13 14:57 ` [PATCH 5/7] x86: memtest: add additional (silly) test patterns Andreas Herrmann
2009-02-13 14:59 ` [PATCH 6/7] x86: memtest: wipe out test pattern from memory Andreas Herrmann
2009-02-13 15:00 ` [PATCH 7/7] x86: update description for memtest boot parameter Andreas Herrmann
-- strict thread matches above, loose matches on Subject: below --
2009-02-25 10:23 [PATCH 0/7 v2] x86: memtest update Andreas Herrmann
2009-02-25 10:28 ` [PATCH 4/7] x86: memtest: adapt log messages Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217102933.GD6298@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.