From: "H. Peter Anvin" <hpa@zytor.com>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] x86: memtest: introduce array to store memtest patterns
Date: Fri, 13 Feb 2009 09:52:31 -0800 [thread overview]
Message-ID: <4995B35F.5080708@zytor.com> (raw)
In-Reply-To: <20090213145124.GB13000@alberich.amd.com>
Andreas Herrmann wrote:
> -#define _MAX_MEM_PATTERNS 4
> +static unsigned long patterns[] = {
> + 0UL,
> + -1UL,
> +#ifdef CONFIG_X86_64
> + 0x5555555555555555UL,
> + 0xaaaaaaaaaaaaaaaaUL,
> +#else
> + 0x55555555UL,
> + 0xaaaaaaaaUL,
> +#endif
> +};
Why not just use u64 for the pattern even on 32 bits?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-02-13 17:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 14:46 [PATCH 0/7] x86: memtest update Andreas Herrmann
2009-02-13 14:49 ` [PATCH 1/7] x86: memtest: reuse test patterns when memtest parameter exceeds number of available patterns Andreas Herrmann
2009-02-13 14:51 ` [PATCH 2/7] x86: memtest: introduce array to store memtest patterns Andreas Herrmann
2009-02-13 17:52 ` H. Peter Anvin [this message]
2009-02-17 10:24 ` Andreas Herrmann
2009-02-17 20:58 ` Yinghai Lu
2009-02-13 14:52 ` [PATCH 3/7] x86: memtest: cleanup memtest function Andreas Herrmann
2009-02-13 14:55 ` [PATCH 4/7] x86: memtest: adapt log messages Andreas Herrmann
2009-02-13 16:53 ` Ingo Molnar
2009-02-13 17:04 ` Jaswinder Singh Rajput
2009-02-13 17:46 ` H. Peter Anvin
2009-02-17 10:27 ` Andreas Herrmann
2009-02-17 10:29 ` Andreas Herrmann
2009-02-13 14:57 ` [PATCH 5/7] x86: memtest: add additional (silly) test patterns Andreas Herrmann
2009-02-13 14:59 ` [PATCH 6/7] x86: memtest: wipe out test pattern from memory Andreas Herrmann
2009-02-13 15:00 ` [PATCH 7/7] x86: update description for memtest boot parameter Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995B35F.5080708@zytor.com \
--to=hpa@zytor.com \
--cc=andreas.herrmann3@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.