Re: mmotm 2009-02-17-12-33 uploaded (nr_pdflush_threads_min sysctl build error)

[Andrew Morton <akpm@linux-foundation.org>]

On Tue, 17 Feb 2009 16:52:49 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-02-17-12-33 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> 
> 
> Is there any CONFIG_ symbol associated with $subject sysctl?

Nope.

> 'one' is only available (currently) when:
> 
> #if defined(CONFIG_DETECT_HUNG_TASK) || defined(CONFIG_DETECT_SOFTLOCKUP) || defined(CONFIG_HIGHMEM)
> static int one = 1;
> #endif
> 
> so it gives us
> kernel/sysctl.c:1067: error: 'one' undeclared here (not in a function)
> 
> when one of those is not #defined.

OK, thanks.

--- a/kernel/sysctl.c~mm-add-proc-controls-for-pdflush-threads-fix-99
+++ a/kernel/sysctl.c
@@ -91,10 +91,7 @@ extern int sysctl_nr_trim_pages;
 extern int rcutorture_runnable;
 #endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
 
-/* Constants used for minimum and  maximum */
-#if defined(CONFIG_DETECT_HUNG_TASK) || defined(CONFIG_DETECT_SOFTLOCKUP) || defined(CONFIG_HIGHMEM)
-static int one = 1;
-#endif
+/* Constants used for minimum and maximum */
 #ifdef CONFIG_DETECT_SOFTLOCKUP
 static int sixty = 60;
 static int neg_one = -1;
@@ -105,6 +102,7 @@ static int two = 2;
 #endif
 
 static int zero;
+static int one = 1;
 static unsigned long one_ul = 1;
 static int one_hundred = 100;
 static int one_thousand = 1000;
diff -puN mm/pdflush.c~mm-add-proc-controls-for-pdflush-threads-fix-99 mm/pdflush.c
_