Re: mmotm 2009-02-17-12-33 uploaded

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 18 Feb 2009 10:35:23 +0100 Jiri Slaby <jirislaby@gmail.com> wrote:

> On 18.2.2009 10:19, Jiri Slaby wrote:
> > On 18.2.2009 00:21, Jiri Slaby wrote:
> >> On 17.2.2009 21:33, akpm@linux-foundation.org wrote:
> >>> The mm-of-the-moment snapshot 2009-02-17-12-33 has been uploaded to
> >
> > This one:
> > kthreads-move-sched-realeted-initialization-from-kthreadd-context.patch
> 
> This hunk fixes the problem for me. I have no idea if it is correct though.
> 
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index c1c3763..caed471 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -73,6 +73,7 @@ static int kthread(void *_create)
> 
>          /* OK, tell user we're spawned, wait for stop or wakeup */
>          __set_current_state(TASK_UNINTERRUPTIBLE);
> +       create->result = current;
>          complete(&create->done);
>          schedule();

hm, it does seem to forget to initialise ->result on the success path.

Someone else has been mucking with kthread.c in linux-next, and a
couple of days ago that mucking got dropped from linux-next.  Perhaps
this churn broke Oleg's patch.

And if it was Stephen who dropped the offending tree, that mucking
about will come back soon and will re-muck things up.

<checks>

	Undropped tree:
		rr

And what does that do?  yup,

--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -76,6 +76,7 @@ static int kthread(void *_create)
 
 	/* OK, tell user we're spawned, wait for stop or wakeup */
 	__set_current_state(TASK_UNINTERRUPTIBLE);
+	create->result = current;
 	complete(&create->started);
 	schedule();
 

guys, please stop mucking things up?