From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Kazuto Miyoshi <miyoshi@linux.bs1.fc.nec.co.jp>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH] Add tracepoints to track pagecache transition
Date: Thu, 19 Feb 2009 13:51:54 -0500 [thread overview]
Message-ID: <20090219185154.GA24117@infradead.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0902171021320.910@gandalf.stny.rr.com>
On Tue, Feb 17, 2009 at 10:24:46AM -0500, Steven Rostedt wrote:
>
> On Tue, 17 Feb 2009, Atsushi Tsuji wrote:
> > >
> > > This is rather asymmetric, why don't we care about the offset for the
> > > removed page?
> > >
> >
> > Indeed.
> > I added the offset to the argument for the removed page and resend fixed patch.
> >
> > Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
>
> Could you package it up in one patch again and resend with [PATCH v2].
> Also make sure to Cc the memory folks, and ask for an Acked-by from them.
Well, until we actually get a consumer of those tracepoints, e.g. a
ftrace pluging into the tree strong NACK for me.
(p.s. I really don't get it why people keep trying to push dead code
into the tree)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Kazuto Miyoshi <miyoshi@linux.bs1.fc.nec.co.jp>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH] Add tracepoints to track pagecache transition
Date: Thu, 19 Feb 2009 13:51:54 -0500 [thread overview]
Message-ID: <20090219185154.GA24117@infradead.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0902171021320.910@gandalf.stny.rr.com>
On Tue, Feb 17, 2009 at 10:24:46AM -0500, Steven Rostedt wrote:
>
> On Tue, 17 Feb 2009, Atsushi Tsuji wrote:
> > >
> > > This is rather asymmetric, why don't we care about the offset for the
> > > removed page?
> > >
> >
> > Indeed.
> > I added the offset to the argument for the removed page and resend fixed patch.
> >
> > Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
>
> Could you package it up in one patch again and resend with [PATCH v2].
> Also make sure to Cc the memory folks, and ask for an Acked-by from them.
Well, until we actually get a consumer of those tracepoints, e.g. a
ftrace pluging into the tree strong NACK for me.
(p.s. I really don't get it why people keep trying to push dead code
into the tree)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-19 18:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 9:00 [PATCH] Add tracepoints to track pagecache transition Atsushi Tsuji
2009-02-17 9:33 ` Peter Zijlstra
2009-02-17 9:33 ` Peter Zijlstra
2009-02-17 11:04 ` Atsushi Tsuji
2009-02-17 11:04 ` Atsushi Tsuji
2009-02-17 11:38 ` KOSAKI Motohiro
2009-02-17 11:38 ` KOSAKI Motohiro
2009-02-17 11:54 ` Peter Zijlstra
2009-02-17 11:54 ` Peter Zijlstra
2009-02-17 12:33 ` KOSAKI Motohiro
2009-02-17 12:33 ` KOSAKI Motohiro
2009-02-17 14:33 ` Frederic Weisbecker
2009-02-17 14:33 ` Frederic Weisbecker
2009-02-18 0:29 ` KOSAKI Motohiro
2009-02-18 0:29 ` KOSAKI Motohiro
2009-02-19 4:41 ` Atsushi Tsuji
2009-02-19 4:41 ` Atsushi Tsuji
2009-02-19 13:12 ` KOSAKI Motohiro
2009-02-19 13:12 ` KOSAKI Motohiro
2009-02-19 14:21 ` Lee Schermerhorn
2009-02-19 14:21 ` Lee Schermerhorn
2009-02-20 1:13 ` KOSAKI Motohiro
2009-02-20 1:13 ` KOSAKI Motohiro
2009-02-17 15:24 ` Steven Rostedt
2009-02-17 15:24 ` Steven Rostedt
2009-02-19 18:51 ` Christoph Hellwig [this message]
2009-02-19 18:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219185154.GA24117@infradead.org \
--to=hch@infradead.org \
--cc=a-tsuji@bk.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fche@redhat.com \
--cc=hugh@veritas.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=miyoshi@linux.bs1.fc.nec.co.jp \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.