From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
Alexey Dobriyan
<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC][PATCH 1/5] create fs flag to mark c/r supported fs's
Date: Thu, 19 Feb 2009 14:00:09 -0500 [thread overview]
Message-ID: <20090219190009.GC28490@infradead.org> (raw)
In-Reply-To: <20090219182007.B4B47C1F@kernel>
On Thu, Feb 19, 2009 at 10:20:07AM -0800, Dave Hansen wrote:
>
> There are plenty of filesystems that are not supported for
> c/r at this point. Think of things like hugetlbfs which
> are externally visible or pipefs which are kernel-internal.
>
> This provides a quick way to make the "normal" filesystems
> which are currently supported. This is also safe if any
> new code gets added. We assume that a fs is non-supported
> unless someone takes explicit action to the contrary.
>
> I bet there are some more filesystems that are OK, but
> these probably cover 99% of the users for now.
Given that a normal fs should be checkpointable you should
make those exposing internal state, not the other way around.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>,
containers <containers@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Oren Laadan <orenl@cs.columbia.edu>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [RFC][PATCH 1/5] create fs flag to mark c/r supported fs's
Date: Thu, 19 Feb 2009 14:00:09 -0500 [thread overview]
Message-ID: <20090219190009.GC28490@infradead.org> (raw)
In-Reply-To: <20090219182007.B4B47C1F@kernel>
On Thu, Feb 19, 2009 at 10:20:07AM -0800, Dave Hansen wrote:
>
> There are plenty of filesystems that are not supported for
> c/r at this point. Think of things like hugetlbfs which
> are externally visible or pipefs which are kernel-internal.
>
> This provides a quick way to make the "normal" filesystems
> which are currently supported. This is also safe if any
> new code gets added. We assume that a fs is non-supported
> unless someone takes explicit action to the contrary.
>
> I bet there are some more filesystems that are OK, but
> these probably cover 99% of the users for now.
Given that a normal fs should be checkpointable you should
make those exposing internal state, not the other way around.
next prev parent reply other threads:[~2009-02-19 19:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 18:20 [RFC][PATCH 1/5] create fs flag to mark c/r supported fs's Dave Hansen
2009-02-19 18:20 ` Dave Hansen
2009-02-19 18:20 ` [RFC][PATCH 2/5] file c/r: expose functions to query fs support Dave Hansen
2009-02-19 18:20 ` Dave Hansen
2009-02-19 18:20 ` [RFC][PATCH 3/5] check files for checkpointability Dave Hansen
2009-02-19 18:20 ` Dave Hansen
2009-02-23 23:49 ` Serge E. Hallyn
2009-02-23 23:49 ` Serge E. Hallyn
2009-02-24 0:30 ` Dave Hansen
2009-02-24 1:10 ` Serge E. Hallyn
[not found] ` <20090224011037.GB4797-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 1:20 ` Dave Hansen
2009-02-24 1:20 ` Dave Hansen
2009-02-24 19:43 ` Serge E. Hallyn
[not found] ` <20090224194329.GC24007-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 19:47 ` Dave Hansen
2009-02-24 19:47 ` Dave Hansen
2009-02-24 19:43 ` Serge E. Hallyn
2009-02-24 1:10 ` Serge E. Hallyn
[not found] ` <20090223234911.GB2590-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-02-24 0:30 ` Dave Hansen
2009-02-19 18:20 ` [RFC][PATCH 4/5] breakout fdinfo sprintf() into its own function Dave Hansen
2009-02-19 18:20 ` Dave Hansen
2009-02-19 18:20 ` [RFC][PATCH 5/5] add c/r info to fdinfo Dave Hansen
2009-02-19 18:20 ` Dave Hansen
2009-02-19 18:23 ` [RFC][PATCH 1/5] create fs flag to mark c/r supported fs's Dave Hansen
2009-02-19 18:23 ` Dave Hansen
2009-02-19 19:00 ` Christoph Hellwig [this message]
2009-02-19 19:00 ` Christoph Hellwig
[not found] ` <20090219190009.GC28490-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2009-02-19 19:24 ` Dave Hansen
2009-02-19 19:24 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219190009.GC28490@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.