From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Liu Yu <yu.liu@freescale.com>,
hollisb@us.ibm.com, kvm-ppc@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500
Date: Thu, 19 Feb 2009 22:41:53 +0000 [thread overview]
Message-ID: <20090219224153.GE27283@hall.aurel32.net> (raw)
In-Reply-To: <f43fc5580902170655w4dadb1aem31bf8d5d6742d50e@mail.gmail.com>
On Tue, Feb 17, 2009 at 04:55:51PM +0200, Blue Swirl wrote:
> On 2/17/09, Liu Yu <yu.liu@freescale.com> wrote:
> > MPIC and OpenPIC have very similar design.
> > So a lot of code can be reused.
> >
> > Modification mainly include:
> > 1. keep struct openpic_t to the maximum size of both MPIC and OpenPIC.
> > 2. endianess swap.
> > MPIC has the same endianess as target, so no need to swap for MPIC.
>
> I don't think this is correct, the host can still be different endian
> from target.
>
I do not agree. As long as we don't manipulate host memory, the host
endianess has nothing to do. The values are simply passed by value, they
don't need to be swapped.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Liu Yu <yu.liu@freescale.com>,
hollisb@us.ibm.com, kvm-ppc@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform.
Date: Thu, 19 Feb 2009 23:41:53 +0100 [thread overview]
Message-ID: <20090219224153.GE27283@hall.aurel32.net> (raw)
In-Reply-To: <f43fc5580902170655w4dadb1aem31bf8d5d6742d50e@mail.gmail.com>
On Tue, Feb 17, 2009 at 04:55:51PM +0200, Blue Swirl wrote:
> On 2/17/09, Liu Yu <yu.liu@freescale.com> wrote:
> > MPIC and OpenPIC have very similar design.
> > So a lot of code can be reused.
> >
> > Modification mainly include:
> > 1. keep struct openpic_t to the maximum size of both MPIC and OpenPIC.
> > 2. endianess swap.
> > MPIC has the same endianess as target, so no need to swap for MPIC.
>
> I don't think this is correct, the host can still be different endian
> from target.
>
I do not agree. As long as we don't manipulate host memory, the host
endianess has nothing to do. The values are simply passed by value, they
don't need to be swapped.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2009-02-19 22:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 9:59 powerpc/kvm: Add MPC8544DS board support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 9:59 ` [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 9:59 ` [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 9:59 ` [PATCH 3/5] kvm/powerpc: Add irq support for E500 core Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 9:59 ` [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 9:59 ` [PATCH 5/5] kvm/powerpc: flat device tree files for MPC8544DS Liu Yu
2009-02-17 9:59 ` [Qemu-devel] " Liu Yu
2009-02-17 15:28 ` [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support Blue Swirl
2009-02-17 15:28 ` Blue Swirl
2009-02-18 7:01 ` Liu Yu-B13201
2009-02-18 7:01 ` Liu Yu-B13201
2009-02-17 15:09 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci Blue Swirl
2009-02-17 15:09 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support Blue Swirl
2009-02-17 16:08 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci M. Warner Losh
2009-02-17 16:08 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support M. Warner Losh
2009-02-17 16:23 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci M. Warner Losh
2009-02-17 16:23 ` [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support M. Warner Losh
2009-02-17 17:41 ` Jamie Lokier
2009-02-18 6:04 ` Liu Yu-B13201
2009-02-18 6:04 ` Liu Yu-B13201
2009-02-17 14:55 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 Blue Swirl
2009-02-17 14:55 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Blue Swirl
2009-02-18 7:17 ` Liu Yu-B13201
2009-02-18 7:17 ` Liu Yu-B13201
2009-02-19 22:41 ` Aurelien Jarno [this message]
2009-02-19 22:41 ` Aurelien Jarno
2009-02-20 17:20 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 Blue Swirl
2009-02-20 17:20 ` [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform Blue Swirl
2009-02-19 23:09 ` Paulev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219224153.GE27283@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=yu.liu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.